Bug 100910

Summary: Remove unused Locale::parseDateTime
Product: WebKit Reporter: Kent Tamura <tkent>
Component: PlatformAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, mifenton, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100935    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Kent Tamura 2012-10-31 18:55:31 PDT 
Remove unused Locale::parseDateTime
Comment 1 Kent Tamura 2012-10-31 19:03:33 PDT 
Created attachment 171756 [details]
Patch
Comment 2 Kentaro Hara 2012-10-31 23:27:10 PDT 
Comment on attachment 171756 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171756&action=review

> Source/WebCore/ChangeLog:7
> +

Would you describe why parseDateTime() is unused? (I wonder why.)
Comment 3 Kent Tamura 2012-10-31 23:45:33 PDT 
Comment on attachment 171756 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171756&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> Would you describe why parseDateTime() is unused? (I wonder why.)

The comment in BaseDateAndTimeInputType::convertFromVisibleValue explains it.  I'll explain in ChangeLog too.
Comment 4 Kentaro Hara 2012-10-31 23:52:07 PDT 
Comment on attachment 171756 [details]
Patch

Makes sense.
Comment 5 Kent Tamura 2012-10-31 23:55:59 PDT 
Created attachment 171782 [details]
Patch for landing

Update ChangeLog
Comment 6 WebKit Review Bot 2012-11-01 00:32:20 PDT 
Comment on attachment 171782 [details]
Patch for landing

Clearing flags on attachment: 171782

Committed r133134: <http://trac.webkit.org/changeset/133134>
Comment 7 WebKit Review Bot 2012-11-01 00:32:24 PDT 
All reviewed patches have been landed.  Closing bug.