Bug 100793

Summary:

clean up tests for webkit-patch rebaseline* commands

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

100562

Attachments:

Description	Flags
Patch	none
Patch	none
rename klass to command_constructor	ojan: review+

Dirk Pranke

Reported 2012-10-30 15:13:00 PDT

clean up tests for webkit-patch rebaseline* commands

Attachments
Patch (55.88 KB, patch) 2012-10-30 15:15 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
Patch (22.49 KB, patch) 2012-10-30 15:23 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
rename klass to command_constructor (55.96 KB, patch) 2012-10-30 15:44 PDT, Dirk Pranke	ojan: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2012-10-30 15:15:31 PDT

Created attachment 171526 [details] Patch

Ojan Vafai

Comment 2 2012-10-30 15:19:50 PDT

Comment on attachment 171526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review > Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41 > + klass = None klass?

Ojan Vafai

Comment 3 2012-10-30 15:22:06 PDT

Comment on attachment 171526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review >> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41 >> + klass = None > > klass? Sorry, I understand why not "class", but why not a descriptive name, e.g. commandConstructor?

Dirk Pranke

Comment 4 2012-10-30 15:23:47 PDT

Created attachment 171529 [details] Patch

Dirk Pranke

Comment 5 2012-10-30 15:26:08 PDT

Comment on attachment 171529 [details] Patch wrong bug, ignore.

Dirk Pranke

Comment 6 2012-10-30 15:27:11 PDT

(In reply to comment #3) > (From update of attachment 171526 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171526&action=review > > >> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:41 > >> + klass = None > > > > klass? > > Sorry, I understand why not "class", but why not a descriptive name, e.g. commandConstructor? "klass" is a pretty common python name for a variable that points to a class object, but I can change it to commandConstructor if you think that's better ...

Dirk Pranke

Comment 7 2012-10-30 15:44:30 PDT

Created attachment 171538 [details] rename klass to command_constructor

Ojan Vafai

Comment 8 2012-10-30 15:52:05 PDT

Comment on attachment 171538 [details] rename klass to command_constructor FWIW, tony was happy with klass. I'm happier now though. :)

Dirk Pranke

Comment 9 2012-10-30 16:22:25 PDT

Committed r132957: <http://trac.webkit.org/changeset/132957>

Note You need to log in before you can comment on or make changes to this bug.