Bug 100349

Summary:

Init timeout flag in ResourceErrorCF

Product:

WebKit

Reporter:

Dominik Röttsches (drott) <d-r>

Component:

Platform

Assignee:

Dominik Röttsches (drott) <d-r>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ap, roger_fong, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

100509

Bug Blocks:

98397

Attachments:

Description	Flags
Patch	none

Dominik Röttsches (drott)

Reported 2012-10-25 01:24:26 PDT

Similar to bug 99478, we'd need to initialize the timeout flag from the CFError in order for XHR timeouts to work (Bug 74802).

Attachments
Patch (1.60 KB, patch) 2012-10-25 01:27 PDT, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dominik Röttsches (drott)

Comment 1 2012-10-25 01:27:44 PDT

Created attachment 170583 [details] Patch

Dominik Röttsches (drott)

Comment 2 2012-10-25 01:30:29 PDT

Roger, do you have an Apple Win build where you could test this?

Dominik Röttsches (drott)

Comment 3 2012-10-25 01:32:04 PDT

This should fix the failures on the Apple Win 7 Release bot for the following test cases: http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html

Dominik Röttsches (drott)

Comment 4 2012-10-25 07:40:59 PDT

Alternatively, can we commit this experimentally and see whether the tests then pass on the bot?

Alexey Proskuryakov

Comment 5 2012-10-25 09:09:48 PDT

Comment on attachment 170583 [details] Patch > Alternatively, can we commit this experimentally and see whether the tests then pass on the bot? I think that we should.

WebKit Review Bot

Comment 6 2012-10-25 09:29:01 PDT

Comment on attachment 170583 [details] Patch Clearing flags on attachment: 170583 Committed r132493: <http://trac.webkit.org/changeset/132493>

WebKit Review Bot

Comment 7 2012-10-25 09:29:05 PDT

All reviewed patches have been landed. Closing bug.

Dominik Röttsches (drott)

Comment 8 2012-10-25 10:37:59 PDT

Looks like it didn't quite cut it, but there's some hiccup with the buildmaster, let's have a look later again: http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29256

Roger Fong

Comment 9 2012-10-25 10:44:54 PDT

Ah, sorry, I do have a windows build. I'll test it out there as well.

Roger Fong

Comment 10 2012-10-25 12:12:16 PDT

still broken, is there a feature define I need to enable?

WebKit Review Bot

Comment 11 2012-10-26 05:21:47 PDT

Re-opened since this is blocked by bug 100509

Dominik Röttsches (drott)

Comment 12 2012-10-26 05:26:27 PDT

Experimental fix rolled out in r132630.

Dominik Röttsches (drott)

Comment 13 2012-10-26 05:57:11 PDT

Skipped for Win in r132638.

Dominik Röttsches (drott)

Comment 14 2012-10-26 05:59:32 PDT

(In reply to comment #10) > still broken, is there a feature define I need to enable? There wasn't, but now there is, cmp. http://trac.webkit.org/changeset/132513 I currently have no build to test or work on this. If you'd like to take a look, the issue most like is just about checking what error code is CFNetworking is returning and then intializing the ResourceErrorBase's m_isTimeout to true, similar to the patch I tried.

David Kilzer (:ddkilzer)

Comment 15 2012-11-14 17:02:50 PST