Bug 100349

Summary: Init timeout flag in ResourceErrorCF
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: PlatformAssignee: Dominik Röttsches (drott) <d-r>
Severity: Normal CC: ap, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100509    
Bug Blocks: 98397    
Description Flags
Patch none

Description Dominik Röttsches (drott) 2012-10-25 01:24:26 PDT
Similar to bug 99478, we'd need to initialize the timeout flag from the CFError in order for XHR timeouts to work (Bug 74802).
Comment 1 Dominik Röttsches (drott) 2012-10-25 01:27:44 PDT
Created attachment 170583 [details]
Comment 2 Dominik Röttsches (drott) 2012-10-25 01:30:29 PDT
Roger, do you have an Apple Win build where you could test this?
Comment 3 Dominik Röttsches (drott) 2012-10-25 01:32:04 PDT
This should fix the failures on the Apple Win 7 Release bot for the following test cases:
Comment 4 Dominik Röttsches (drott) 2012-10-25 07:40:59 PDT
Alternatively, can we commit this experimentally and see whether the tests then pass on the bot?
Comment 5 Alexey Proskuryakov 2012-10-25 09:09:48 PDT
Comment on attachment 170583 [details]

> Alternatively, can we commit this experimentally and see whether the tests then pass on the bot?

I think that we should.
Comment 6 WebKit Review Bot 2012-10-25 09:29:01 PDT
Comment on attachment 170583 [details]

Clearing flags on attachment: 170583

Committed r132493: <http://trac.webkit.org/changeset/132493>
Comment 7 WebKit Review Bot 2012-10-25 09:29:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Dominik Röttsches (drott) 2012-10-25 10:37:59 PDT
Looks like it didn't quite cut it, but there's some hiccup with the buildmaster, let's have a look later again:
Comment 9 Roger Fong 2012-10-25 10:44:54 PDT
Ah, sorry, I do have a windows build. I'll test it out there as well.
Comment 10 Roger Fong 2012-10-25 12:12:16 PDT
still broken, is there a feature define I need to enable?
Comment 11 WebKit Review Bot 2012-10-26 05:21:47 PDT
Re-opened since this is blocked by bug 100509
Comment 12 Dominik Röttsches (drott) 2012-10-26 05:26:27 PDT
Experimental fix rolled out in r132630.
Comment 13 Dominik Röttsches (drott) 2012-10-26 05:57:11 PDT
Skipped for Win in r132638.
Comment 14 Dominik Röttsches (drott) 2012-10-26 05:59:32 PDT
(In reply to comment #10)
> still broken, is there a feature define I need to enable?

There wasn't, but now there is, cmp.

I currently have no build to test or work on this. If you'd like to take a look, the issue most like is just about checking what error code is CFNetworking is returning and then intializing the ResourceErrorBase's m_isTimeout to true, similar to the patch I tried.
Comment 15 David Kilzer (:ddkilzer) 2012-11-14 17:02:50 PST
See also Bug 102271.
Comment 16 Alexey Proskuryakov 2012-11-14 19:49:44 PST

*** This bug has been marked as a duplicate of bug 102271 ***