Bug 100199

Summary: [EFL][WK2] Make find and form clients C++ classes
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 99992    
Attachments:
Description Flags
Patch
gyuyoung.kim: review+, webkit.review.bot: commit-queue-
Patch for landing none

Chris Dumez
Reported 2012-10-23 22:39:22 PDT
As part of bug 99992, we should move away from C'ism and make the find client a C++ class.
Attachments
Patch (24.15 KB, patch)
2012-10-23 23:44 PDT, Chris Dumez 		gyuyoung.kim: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (24.18 KB, patch)
2012-10-24 02:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-10-23 23:44:37 PDT
Created attachment 170328 [details] Patch
Mikhail Pozdnyakov
Comment 2 2012-10-24 00:07:42 PDT
Comment on attachment 170328 [details] Patch looks nice
WebKit Review Bot
Comment 3 2012-10-24 01:14:20 PDT
Comment on attachment 170328 [details] Patch Rejecting attachment 170328 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 44>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14566117
Chris Dumez
Comment 4 2012-10-24 02:52:56 PDT
Created attachment 170350 [details] Patch for landing Rebase on master. Could someone please cq+?
WebKit Review Bot
Comment 5 2012-10-24 04:02:23 PDT
Comment on attachment 170350 [details] Patch for landing Clearing flags on attachment: 170350 Committed r132334: <http://trac.webkit.org/changeset/132334>
WebKit Review Bot
Comment 6 2012-10-24 04:02:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.