Bug 100076 – exif-orientation tests should use dumpAsText(true)

• Component: Tools / Tests
• Status: RESOLVED FIXED

[noel gordon]

The fast/images/exif-orientation tests use dumpAsText(1).  That's not supported by chromium DRT so NRWT --chromium won't compare the expected pixel results if/when we unskip these tests.

[noel gordon]

Created attachment 170281 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 170281 [details]
Patch

Do some DRT implementations care?

[Eric Seidel (no email)]

Seems reasonable to make chromium DRT support this. :)

[noel gordon]

(In reply to comment #2)

> Do some DRT implementations care?

Chromium DRT doesn't understand an integer argument, it only handles booleans.

http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/DRTTestRunner.cpp?rev=132138#L359

[noel gordon]

(In reply to comment #3)
> Seems reasonable to make chromium DRT support this. :)

Yes, we could that after Stephen fixes the only remaining test using dumpAsText(1) per bug 100074

[noel gordon]

After that, change the DRTTestRunner.cpp?rev=132138#L359 code to read

-    if (arguments.size() > 0 && arguments[0].isBool())
-        m_generatePixelResults = arguments[0].value.boolValue;
+    if (arguments.size() > 0)
+        m_generatePixelResults = cppVariantToBool(arguments[0]);

[WebKit Review Bot]

Comment on attachment 170281 [details]
Patch

Clearing flags on attachment: 170281

Committed r132297: <http://trac.webkit.org/changeset/132297>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.