Bug 8113 - Disable crash report dialogs for testkjs.exe in Release mode
Summary: Disable crash report dialogs for testkjs.exe in Release mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 3356
  Show dependency tree / graph
 
Reported: 2006-03-31 16:20 PST by Björn Graf (boki)
Modified: 2006-04-04 05:06 PDT (History)
1 user (show)

See Also:

Attachments
Adds SEH to main in Release builds (965 bytes, patch)
2006-03-31 16:20 PST, Björn Graf (boki) 		no flags Details | Formatted Diff | Diff
Always use separate main functions (2.20 KB, patch)
2006-04-01 05:52 PST, Björn Graf (boki) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Graf (boki) 2006-03-31 16:20:09 PST 
To simplify running JavaScriptCore/tests/mozilla/jsDriver.pl on Windows use SEH to catch access violation exceptions. That way the crash dialog is not shown and the tests run through without the need to dismiss any dialogs.
Comment 1 Björn Graf (boki) 2006-03-31 16:20:58 PST 
Created attachment 7428 [details]
Adds SEH to main in Release builds
Comment 2 Darin Adler 2006-03-31 23:15:03 PST 
Comment on attachment 7428 [details]
Adds SEH to main in Release builds

Seems like a fine fix, but we don't have to do it in a strange way like this. We can always have the separate main function.
Comment 3 Björn Graf (boki) 2006-04-01 05:52:29 PST 
Created attachment 7440 [details]
Always use separate main functions

This time with some preprocessor voodoo :]
Comment 4 Darin Adler 2006-04-01 08:35:34 PST 
Comment on attachment 7440 [details]
Always use separate main functions

Looks fine. r=me
Comment 5 David Kilzer (:ddkilzer) 2006-04-01 15:15:57 PST 
(In reply to comment #4)
> (From update of attachment 7440 [details] [edit])
> Looks fine. r=me

NOTE: This patch has bits from attachment 7427 [details] from Bug 7399 in it!
Comment 6 Eric Seidel (no email) 2006-04-04 05:06:38 PDT 
Note: This patch is missing a changelog, as well as copyright information.  I will add those as I land this time, but please be sure to include such in your future patches.