Bug 7399 - Integrate CURL version of gettimeofday
Summary: Integrate CURL version of gettimeofday
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 3356
  Show dependency treegraph
 
Reported: 2006-02-20 23:19 PST by Geoffrey Garen
Modified: 2007-09-30 11:02 PDT (History)
4 users (show)

See Also:


Attachments
Quick fix to make StopWatch available on Windows (1.33 KB, patch)
2006-03-31 16:13 PST, Björn Graf (boki)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2006-02-20 23:19:50 PST
CURL (http://curl.haxx.se/) has a platform-independent version of gettimeofday and related helpers. We should integrate it. It will make the StopWatch class in testkjs work on Windows. Long-term, it may also provide a simpler way to write platform independent date code.
Comment 1 Björn Graf (boki) 2006-03-31 16:13:12 PST
Created attachment 7427 [details]
Quick fix to make StopWatch available on Windows
Comment 2 Geoffrey Garen 2006-03-31 16:19:17 PST
Comment on attachment 7427 [details]
Quick fix to make StopWatch available on Windows

OK, but let's keep this bug open, because we still would like to integrate the CURL code.
Comment 3 Björn Graf (boki) 2006-03-31 16:24:47 PST
Maybe the CURL code will fix the issue on Windows where localtime returns 0 for invalid dates which causes lots of crashes with the unchecked dereferencing used all over the place.
Comment 4 Eric Seidel (no email) 2006-04-04 05:06:16 PDT
This patch is missing a ChangeLog as well as copyright.  Please include those in future patches.  I'll add the missing information as I land this time.
Comment 5 Geoffrey Garen 2006-04-04 09:26:25 PDT
Reopening. See my comment above.
Comment 6 Eric Seidel (no email) 2007-09-30 11:02:07 PDT
This bug has been stale for over a year.   The windows port works. :)  I think this can be closed.