Bug 5969 - SVG is missing <mask> support
Summary: SVG is missing <mask> support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Nobody
URL: http://www.w3.org/Graphics/SVG/Test/2...
Keywords:
Depends on: 6327 6337
Blocks:
  Show dependency tree / graph
 
Reported: 2005-12-06 03:54 PST by Eric Seidel (no email)
Modified: 2006-01-06 01:08 PST (History)
0 users

See Also:

Attachments
reduced testcase (996 bytes, image/svg+xml)
2005-12-10 18:19 PST, Alexander Kellett 		no flags Details
reduced testcase (updated) (1011 bytes, image/svg+xml)
2005-12-29 23:39 PST, Alexander Kellett 		no flags Details
preliminary <mask> support (31.72 KB, patch)
2005-12-29 23:45 PST, Alexander Kellett 		no flags Details | Formatted Diff | Diff
preliminary <mask> support patch (32.01 KB, patch)
2005-12-30 00:19 PST, Alexander Kellett 		no flags Details | Formatted Diff | Diff
alpha mask test (977 bytes, image/svg+xml)
2005-12-30 12:51 PST, Alexander Kellett 		no flags Details
cleaned up patch (30.84 KB, patch)
2005-12-30 16:15 PST, Alexander Kellett 		no flags Details | Formatted Diff | Diff
fixing leaks and more style issues noticed by macdome (31.34 KB, patch)
2005-12-30 18:13 PST, Alexander Kellett 		no flags Details | Formatted Diff | Diff
<mask> patch (31.32 KB, patch)
2005-12-30 18:16 PST, Alexander Kellett 		no flags Details | Formatted Diff | Diff
layouttests patch (2.92 KB, patch)
2006-01-03 10:41 PST, Alexander Kellett 		no flags Details | Formatted Diff | Diff
<mask> support, refactored (40.45 KB, patch)
2006-01-03 14:12 PST, Alexander Kellett 		no flags Details | Formatted Diff | Diff
<mask> support, refactored, style changes (40.28 KB, patch)
2006-01-03 14:36 PST, Alexander Kellett 		eric: review+
Details | Formatted Diff | Diff
changelog addition (1.61 KB, text/plain)
2006-01-03 14:51 PST, Alexander Kellett 		no flags Details
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-12-06 03:54:20 PST 
SVG is missing <mask> support

This would be very easy to do (very similar logic to <clippath>)  I just haven't gotten around to it yet.
Comment 1 Alexander Kellett 2005-12-10 18:19:23 PST 
Created attachment 5024 [details]
reduced testcase
Comment 2 Alexander Kellett 2005-12-29 23:39:54 PST 
Created attachment 5370 [details]
reduced testcase (updated)

moved rect outside defs to fix a possible bug in the current implementation
Comment 3 Alexander Kellett 2005-12-29 23:45:30 PST 
Created attachment 5371 [details]
preliminary <mask> support

issues:
   see previously attached comment on testcase (possible bug - related to
<defs>)
   currently does not allow for usage of the alpha in the mask, thusly the
above testcase has been modified to use a black/white gradient instead
   the rgb to grayscale conversion is not per spec

the code to fix the above rgb/rgba related issues has been #ifdef'd out as its
not yet ready for final commit
Comment 4 Alexander Kellett 2005-12-30 00:19:46 PST 
Created attachment 5372 [details]
preliminary <mask> support patch

several style changes following review from macdome
Comment 5 Alexander Kellett 2005-12-30 12:51:00 PST 
Created attachment 5386 [details]
alpha mask test
Comment 6 Alexander Kellett 2005-12-30 16:15:09 PST 
Created attachment 5389 [details]
cleaned up patch
Comment 7 Alexander Kellett 2005-12-30 18:13:42 PST 
Created attachment 5391 [details]
fixing leaks and more style issues noticed by macdome
Comment 8 Alexander Kellett 2005-12-30 18:16:59 PST 
Created attachment 5392 [details]
<mask> patch
Comment 9 Alexander Kellett 2006-01-03 10:41:11 PST 
Created attachment 5453 [details]
layouttests patch
Comment 10 Alexander Kellett 2006-01-03 14:12:53 PST 
Created attachment 5457 [details]
<mask> support, refactored
Comment 11 Alexander Kellett 2006-01-03 14:36:13 PST 
Created attachment 5460 [details]
<mask> support, refactored, style changes
Comment 12 Alexander Kellett 2006-01-03 14:51:28 PST 
Created attachment 5461 [details]
changelog addition
Comment 13 Eric Seidel (no email) 2006-01-03 22:32:57 PST 
Comment on attachment 5460 [details]
<mask> support, refactored, style changes

Looks good!
r=me
Comment 14 Eric Seidel (no email) 2006-01-06 01:08:55 PST 
Basic support landed.  We'll need another bug to cover missing features.