Bug 31026 - [cairo] Remove old workaround from pre-CAIRO_EXTEND_PAD days
Summary: [cairo] Remove old workaround from pre-CAIRO_EXTEND_PAD days
Status: RESOLVED DUPLICATE of bug 19266
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-02 12:06 PST by Benjamin Otte
Modified: 2009-11-03 02:50 PST (History)
3 users (show)

See Also:

Attachments
patch (3.03 KB, patch)
2009-11-02 12:30 PST, Benjamin Otte 		otte: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Otte 2009-11-02 12:06:05 PST 
Back when CAIRO_EXTEND_PAD was not implemented the code used CAIRO_FILTER_NEAREST to avoid a gradient effect at image borders. This patch uses CAIRO_EXTEND_PAD and restores bilinear scaling for images. It also bumps the required Cairo version to 1.6 as CAIRO_EXTEND_PAD was implemented there.

https://bugs.webkit.org/show_bug.cgi?id=14017
Comment 1 Benjamin Otte 2009-11-02 12:30:46 PST 
Created attachment 42335 [details]
patch
Comment 2 Dirk Schulze 2009-11-03 02:28:08 PST 
If you(In reply to comment #1)
> Created an attachment (id=42335) [details]
> patch

If you force Cairo 1.6 as minimum, you could delete the #ifdefs in PathCairo and GraphicsContextCairo as well. And I thnk that we use the webkit coding style on the cairo bits too. So no break between cairo_pattern_set_extend and the brace. I also think that this is a duplication of bug 19266 , right?
Comment 3 Benjamin Otte 2009-11-03 02:49:35 PST 
(In reply to comment #2)
> If you force Cairo 1.6 as minimum, you could delete the #ifdefs in PathCairo
> and GraphicsContextCairo as well. And I thnk that we use the webkit coding
> style on the cairo bits too. So no break between cairo_pattern_set_extend and
> the brace. I also think that this is a duplication of bug 19266 , right?
>
Will do, will fix, yes.

*** This bug has been marked as a duplicate of bug 19266 ***