Bug 14017 - [CAIRO] Unwanted gradient effect for small stretched images
Summary: [CAIRO] Unwanted gradient effect for small stretched images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 14016 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-06 10:50 PDT by Alp Toker
Modified: 2007-08-29 12:27 PDT (History)
1 user (show)

See Also:


Attachments
Screenshot of the bad rendering (82.50 KB, image/png)
2007-06-06 10:58 PDT, Alp Toker
no flags Details
Use CAIRO_FILTER_NEAREST to work around the issue (2.18 KB, patch)
2007-06-06 11:12 PDT, Alp Toker
no flags Details | Formatted Diff | Diff
Use CAIRO_FILTER_NEAREST to work around the issue, take two (2.18 KB, patch)
2007-06-06 11:14 PDT, Alp Toker
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-06-06 10:50:35 PDT
The unwanted effect is seen at http://news.bbc.co.uk/

A screenshot is attached.
Comment 1 Alp Toker 2007-06-06 10:58:16 PDT
Created attachment 14882 [details]
Screenshot of the bad rendering
Comment 2 Alp Toker 2007-06-06 11:12:32 PDT
Created attachment 14883 [details]
Use CAIRO_FILTER_NEAREST to work around the issue
Comment 3 Alp Toker 2007-06-06 11:14:33 PDT
Created attachment 14884 [details]
Use CAIRO_FILTER_NEAREST to work around the issue, take two

Updated with tiny a formatting fix in the ChangeLog entry
Comment 4 Eric Seidel (no email) 2007-06-06 11:19:17 PDT
Comment on attachment 14884 [details]
Use CAIRO_FILTER_NEAREST to work around the issue, take two

Looks sane enough.  r=me.
Comment 5 Sam Weinig 2007-06-06 11:25:49 PDT
Landed in r22030.
Comment 6 Alp Toker 2007-06-07 05:08:26 PDT
*** Bug 14016 has been marked as a duplicate of this bug. ***
Comment 7 George Wright 2007-08-29 12:27:59 PDT
Speaking to the cairo people this may not be the optimal solution to this problem. The gradient is a result of the extend method being set to CAIRO_EXTEND_NONE. If you set it to CAIRO_EXTEND_REPEAT or CAIRO_EXTEND_REFLECT the gradient problem goes away, and it allows for better scaling quality using CAIRO_FILTER_GOOD etc.