Bug 16532 - Inspector should highlight nodes in page when hovering over nodes in Inspector's interface
Summary: Inspector should highlight nodes in page when hovering over nodes in Inspecto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 17777
  Show dependency treegraph
 
Reported: 2007-12-20 08:34 PST by Danny Bloemendaal
Modified: 2008-03-21 07:56 PDT (History)
2 users (show)

See Also:


Attachments
[WIP] Call InspectorController.highlightDOMNode on hover (3.68 KB, patch)
2008-03-19 16:24 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
[1/3] Highlight when hovering in the DOM tree (4.97 KB, patch)
2008-03-20 13:08 PDT, Adam Roben (:aroben)
timothy: review+
Details | Formatted Diff | Diff
[2/3] Highlight when hovering the DOM breadcrumbs (3.54 KB, patch)
2008-03-20 13:08 PDT, Adam Roben (:aroben)
timothy: review+
Details | Formatted Diff | Diff
[3/3] Highlight when hovering in the Console (2.39 KB, patch)
2008-03-20 13:09 PDT, Adam Roben (:aroben)
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Danny Bloemendaal 2007-12-20 08:34:01 PST
Firebug hightlights the element when you hover over an element in the dom tree. So it follows the selection. The good thing with this is that on hover, firebug also shows the paddings and borders of the highlight with a different color so you can quickly over over elements and actually SEE problems with padding and margins. Very very handy.
Comment 1 Adam Roben (:aroben) 2008-01-29 11:09:56 PST
<rdar://problem/5712896>
Comment 2 Adam Roben (:aroben) 2008-03-11 10:01:15 PDT
This bug is now just about highlighting nodes in the page when you hover over them in the DOM tree. Bug 17221 covers showing the nodes' metrics in the node highlight.
Comment 3 Adam Roben (:aroben) 2008-03-19 16:24:20 PDT
Created attachment 19888 [details]
[WIP] Call InspectorController.highlightDOMNode on hover

Not for review yet
Comment 4 Adam Roben (:aroben) 2008-03-20 12:53:30 PDT
We should also highlight nodes when you hover over them in other parts of the Inspector's UI (e.g., the Console).
Comment 5 Adam Roben (:aroben) 2008-03-20 13:08:27 PDT
Created attachment 19905 [details]
[1/3] Highlight when hovering in the DOM tree
Comment 6 Adam Roben (:aroben) 2008-03-20 13:08:48 PDT
Created attachment 19906 [details]
[2/3] Highlight when hovering the DOM breadcrumbs
Comment 7 Adam Roben (:aroben) 2008-03-20 13:09:05 PDT
Created attachment 19907 [details]
[3/3] Highlight when hovering in the Console
Comment 8 Adam Roben (:aroben) 2008-03-20 13:09:51 PDT
We probably shouldn't land these patches until we change the node highlight to be less dramatic. Having the gray overlay come and go quickly is awfully noisy. This will probably be fixed by bug 17221.
Comment 9 Adam Roben (:aroben) 2008-03-20 16:00:23 PDT
Committed these patches in r31190, r31191, and r31192.
Comment 10 Danny Bloemendaal 2008-03-21 01:26:35 PDT
Wow! Great work people!! Another step ahead in the road to a firebug equivalent for webkit!!
Comment 11 Danny Bloemendaal 2008-03-21 01:33:57 PDT
One problem I noticed though is that sometimes the highligh isn't removed and remains on the page. Then, when you scroll the page, the highlight remains on its fixed location which is weird.
Comment 12 Adam Roben (:aroben) 2008-03-21 07:38:26 PDT
(In reply to comment #11)
> One problem I noticed though is that sometimes the highligh isn't removed and
> remains on the page.

Yes, it does seem to be possible to get the highlight to stick around if you move your mouse quickly enough.

> Then, when you scroll the page, the highlight remains on
> its fixed location which is weird.

That is bug 17920.
Comment 13 Adam Roben (:aroben) 2008-03-21 07:40:16 PDT
(In reply to comment #12)
> (In reply to comment #11)
> > One problem I noticed though is that sometimes the highligh isn't removed and
> > remains on the page.
> 
> Yes, it does seem to be possible to get the highlight to stick around if you
> move your mouse quickly enough.

And this is now bug 17982.
Comment 14 Danny Bloemendaal 2008-03-21 07:44:02 PDT
Ok, good. Now we only miss the other way around: in the webinstpector go into 'inspect' mode and hover over elements in the page, display its highlight and select the node in dom tree (after a slight delay).  Just like firebug does when you click the inspect button.
Comment 15 Adam Roben (:aroben) 2008-03-21 07:56:20 PDT
(In reply to comment #14)
> Ok, good. Now we only miss the other way around: in the webinstpector go into
> 'inspect' mode and hover over elements in the page, display its highlight and
> select the node in dom tree (after a slight delay).  Just like firebug does
> when you click the inspect button.

See bug 17772.