RESOLVED FIXED Bug 17221
Node highlight should show node metrics
https://bugs.webkit.org/show_bug.cgi?id=17221
Summary Node highlight should show node metrics
Adam Roben (:aroben)
Reported 2008-02-08 13:41:02 PST
The node highlight should show the highlighted node's metrics overlaid on top of the node. Firebug uses different colors to show the different boxes. It might be nice to show the actual numbers as well, if we can keep them from obscuring things too much.
Attachments
Show content/padding/border/margin boxes for blocks (8.13 KB, patch)
2008-03-20 15:27 PDT, Adam Roben (:aroben)
no flags
Screenshot of new highlight (37.11 KB, image/png)
2008-03-20 15:28 PDT, Adam Roben (:aroben)
no flags
Firebug's highlight (11.19 KB, image/png)
2008-03-20 15:51 PDT, Adam Roben (:aroben)
no flags
Xyle scope's highlight (36.30 KB, image/png)
2008-03-20 15:56 PDT, Timothy Hatcher
no flags
Adam Roben (:aroben)
Comment 1 2008-02-08 14:16:18 PST
Adam Roben (:aroben)
Comment 2 2008-03-20 15:27:13 PDT
Created attachment 19911 [details] Show content/padding/border/margin boxes for blocks Here's a patch that changes our node highlight pretty drastically (screenshot coming). We now outline the content/padding/border/margin boxes for blocks. We don't yet show padding/border/margins for inlines.
Adam Roben (:aroben)
Comment 3 2008-03-20 15:28:10 PDT
Created attachment 19912 [details] Screenshot of new highlight Here's what the highlight implemented by attachment 19911 [details] looks like. I think we'll want to tweak this a bit more, at least to make the different boxes more distinguishable. Firebug uses some high-contrast colors that get the job done, but are a bit ugly.
Adam Roben (:aroben)
Comment 4 2008-03-20 15:51:16 PDT
Created attachment 19913 [details] Firebug's highlight Here's Firebug's highlight, for reference
Timothy Hatcher
Comment 5 2008-03-20 15:56:48 PDT
Created attachment 19914 [details] Xyle scope's highlight
Adam Roben (:aroben)
Comment 6 2008-03-20 15:59:23 PDT
Comment on attachment 19911 [details] Show content/padding/border/margin boxes for blocks Committed in r31189
Adam Roben (:aroben)
Comment 7 2008-04-14 13:15:18 PDT
Reopening as we may want to show numeric metrics in the node highlight as well.
Alexander Pavlov (apavlov)
Comment 8 2011-09-06 07:46:58 PDT
We've had numeric metrics displayed as a tooltip for a while. Bug 37768 patch slightly changed the appearance of the tooltip but it still contains the element renderer's dimensions. Please reopen if you envision something specific that should be implemented.
Note You need to log in before you can comment on or make changes to this bug.