Bug 13382 - [js-collector-tweaks] Remove JS oversize allocator
Summary: [js-collector-tweaks] Remove JS oversize allocator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on: 13381
Blocks: 13383 13389
  Show dependency treegraph
 
Reported: 2007-04-18 00:03 PDT by Maciej Stachowiak
Modified: 2007-04-22 21:02 PDT (History)
0 users

See Also:


Attachments
02-js-gc-forbid-oversize.patch.txt (7.29 KB, patch)
2007-04-18 00:05 PDT, Maciej Stachowiak
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2007-04-18 00:03:39 PDT
With the Window object using the oversize allocator, it can be removed entirely. This depends on the patch in 13381
Comment 1 Maciej Stachowiak 2007-04-18 00:05:38 PDT
Created attachment 14063 [details]
02-js-gc-forbid-oversize.patch.txt
Comment 2 Darin Adler 2007-04-18 11:02:23 PDT
Comment on attachment 14063 [details]
02-js-gc-forbid-oversize.patch.txt

Looks fine.

I would have suggested using a simpler approach for CellSize, using sizeof(void*) as the parmaeter rather than the two booleans, as in the IntTypes template in HashFunctions.h.
Comment 3 Geoffrey Garen 2007-04-18 21:11:19 PDT
Just wondering -- how did you verify that max object size? Can we make that verification happen at compile time?
Comment 4 Maciej Stachowiak 2007-04-22 21:02:30 PDT
I took Darin's preferred approach to the size selection. Re Geoff's comment, I could not figure out a good way to do the check at compile time.