RESOLVED FIXED 13381
[js-collector-tweaks] Make Window object not an oversize object any more 
https://bugs.webkit.org/show_bug.cgi?id=13381
Summary [js-collector-tweaks] Make Window object not an oversize object any more
Maciej Stachowiak
Reported 2007-04-18 00:02:23 PDT
Window is the only object to make use of the JavaCriptCore oversize allocator; avoiding use of this should speed up garbage collection when there are many tabs/windows/frames open, and also enables a bunch of further optimizations to the collector.
Attachments
01-js-gc-window-not-oversize.patch.txt (23.86 KB, patch)
2007-04-18 00:04 PDT, Maciej Stachowiak 		darin: review-
DetailsFormatted DiffDiff
omitting optimization level changes (23.04 KB, patch)
2007-04-18 14:56 PDT, Maciej Stachowiak 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2007-04-18 00:04:51 PDT
Created attachment 14062 [details] 01-js-gc-window-not-oversize.patch.txt
Darin Adler
Comment 2 2007-04-18 10:58:25 PDT
Comment on attachment 14062 [details] 01-js-gc-window-not-oversize.patch.txt Optimization level changes should be done in Configurations/Base.xcconfig instead of in the project.pbxproj. Change otherwise looks fine to me. Although I'm not crazy about the name "d".
Maciej Stachowiak
Comment 3 2007-04-18 14:56:29 PDT
Created attachment 14081 [details] omitting optimization level changes The optimization level changes were accidental.
Geoffrey Garen
Comment 4 2007-04-18 21:13:35 PDT
Comment on attachment 14081 [details] omitting optimization level changes r=me
Note You need to log in before you can comment on or make changes to this bug.