Bug 12851 – improve gdk's notImplemented() macro

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Krzysztof Kowalczyk]

Improve gdk's notImplemented() macro

[Krzysztof Kowalczyk]

Created attachment 13309 [details]
improve gdk's notImplemented() macro

Improve gdk's notImplemented() macro():
* as suggested per Adam Roben in http://bugs.webkit.org/show_bug.cgi?id=12785, only print once per function, so that frequently called functions don't clutter the output
* rename to notImplementedGdk() to give it a unique name (so that it doesn't clash with notImplemented() for other platforms)
* Don't print the warning if DISABLE_NI_WARNING env variable is set.

Is it ok to move notImplementedGdk() to some common place (e.g. config.h) to avoid duplicating the code? If yes, I'll submit a patch for that in the future (I renamed the macro to notImplementedGdk() in anticipation of that).

[Adam Roben (:aroben)]

Comment on attachment 13309 [details]
improve gdk's notImplemented() macro

+#define notImplementedGdk() do { \
+    static int count; \
+    if (!count && !getenv("DISABLE_NI_WARNING")) \
+        fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", WTF_PRETTY_FUNCTION, __FILE__, __LINE__); \
+    ++count; \
+ } while(0)

   Might as well just use a "bool printed" instead of "int count".

   Instead of putting this in config.h, you should probably just create your own header platform/gdk/NotImplemented.h that only contains this macro.

   You might also want to uncomment any other notImplemented() calls that were commented out for being too chatty.

   r=me.

[Krzysztof Kowalczyk]

landed in r19788. More improvements coming.