Bug 12785 - Linux/gdk improvements
Summary: Linux/gdk improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-15 23:00 PST by Krzysztof Kowalczyk
Modified: 2007-02-16 22:46 PST (History)
0 users

See Also:


Attachments
move Path to its own file, GraphicsContext cairo additions (9.84 KB, patch)
2007-02-15 23:04 PST, Krzysztof Kowalczyk
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kowalczyk 2007-02-15 23:00:28 PST
Move Path for cairo to its own file. Implement GraphicsContext's setLineCap(), setLineJoin() and setMiterLimit() for cairo.
Comment 1 Krzysztof Kowalczyk 2007-02-15 23:04:55 PST
Created attachment 13197 [details]
move Path to its own file, GraphicsContext cairo additions
Comment 2 Adam Roben (:aroben) 2007-02-16 21:38:21 PST
Comment on attachment 13197 [details]
move Path to its own file, GraphicsContext cairo additions

-    notImplemented();
+    // notImplemented(); // commented-out because it's chatty and clutters output

   A better fix might be to make notImplemented() only print once per function, as opposed to once per call.

   You should also set svn:eol-style native on all new files.

   r=me
Comment 3 Krzysztof Kowalczyk 2007-02-16 22:46:04 PST
committed in r19675. set svn:eol-style to native as per review comment.

The suggestion to only print notImplemented() message once is good - maybe in future patches.