Bug 12011 - svg/custom/dynamic-svg-document-creation.svg is failing
Summary: svg/custom/dynamic-svg-document-creation.svg is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-27 19:39 PST by Geoffrey Garen
Modified: 2006-12-28 01:06 PST (History)
1 user (show)

See Also:

Attachments
Fix testcase (1.09 KB, patch)
2006-12-28 00:56 PST, Rob Buis 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2006-12-27 19:39:46 PST 
This is the change that broke it:

Changed by: rwlbuis
Changed at: Thu 28 Dec 2006 11:12:41
Revision: 18440

Changed files:

/LayoutTests/ChangeLog
/LayoutTests/svg/custom/transform-invalid-expected.txt
/LayoutTests/svg/custom/transform-invalid.svg
/WebCore/CMakeLists.txt
/WebCore/ChangeLog
/WebCore/WebCore.xcodeproj/project.pbxproj
/WebCore/ksvg2/svg/SVGParserUtilities.cpp
/WebCore/ksvg2/svg/SVGParserUtilities.h
/WebCore/ksvg2/svg/SVGPathElement.cpp
/WebCore/ksvg2/svg/SVGPathElement.h
/WebCore/ksvg2/svg/SVGTransformable.cpp
/WebCore/ksvg2/svg/svgpathparser.cpp
/WebCore/ksvg2/svg/svgpathparser.h
Comments:
        Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=11108
        Replace usage of split by proper parsers 
        http://bugs.webkit.org/show_bug.cgi?id=11908
        WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes 
        Get rid of split() when parsing transform attribute.
Comment 1 Rob Buis 2006-12-28 00:56:01 PST 
Created attachment 12079 [details]
Fix testcase
Comment 2 mitz 2006-12-28 00:59:12 PST 
Comment on attachment 12079 [details]
Fix testcase

r=me
Comment 3 Rob Buis 2006-12-28 01:06:45 PST 
Landed in r18450.