Bug 11908 - WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes
Summary: WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://xml2.mweb.co.za/clipart/plants...
Keywords:
Depends on: 11108
Blocks:
  Show dependency tree / graph
 
Reported: 2006-12-21 05:16 PST by Eric Seidel (no email)
Modified: 2006-12-27 15:27 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-12-21 05:16:14 PST 
WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes

This function:
bool SVGTransformable::parseTransformAttribute(SVGTransformList* list, const AtomicString& transform)

Uses a regex for parsing.  Ick.

that's eating 40% of our time while parsing, at least when displaying bamboo.svg  I think a simpler, custom parser is in order.
Comment 1 Eric Seidel (no email) 2006-12-21 05:17:19 PST 
it's actually bamboo_01.svg

http://xml2.mweb.co.za/clipart/plants/bamboo_01.svg

Save it locally for proper testing.
Comment 2 mitz 2006-12-21 06:47:40 PST 
(In reply to comment #0)

> I think a simpler, custom parser is in order.

See attachment 10944 [details] in bug 11108.
Comment 3 Rob Buis 2006-12-22 13:46:38 PST 
Hi Eric, Mitz,

(In reply to comment #2)
> (In reply to comment #0)
> 
> > I think a simpler, custom parser is in order.
> 
> See attachment 10944 [details] [edit] in bug 11108.

I created a new patch that actually compiles on ToT :) I'd love it if someone could take it and shark it with bamboo.svg, since I am away for at least 24h.
Cheers,

Rob.
Comment 4 Rob Buis 2006-12-27 15:25:25 PST 
Landed in r18440.
Comment 5 Rob Buis 2006-12-27 15:27:39 PST 
Landed in r18440.