RESOLVED WORKSFORME 10187
REGRESSION: Mangled focus ring
https://bugs.webkit.org/show_bug.cgi?id=10187
Summary REGRESSION: Mangled focus ring
Alexander Kellett
Reported 2006-08-01 11:39:06 PDT
Go to above page. Tab to the comment form field. Notice the very strange shape of the focus ring.
Attachments
Test case reduction (390 bytes, text/html)
2006-08-05 09:30 PDT, jonathanjohnsson
no flags
David Kilzer (:ddkilzer)
Comment 1 2006-08-01 15:02:58 PDT
Similar to Bug 10049 for NativePopUp?
jonathanjohnsson
Comment 2 2006-08-05 09:30:52 PDT
Created attachment 9892 [details] Test case reduction
David Kilzer (:ddkilzer)
Comment 3 2006-08-05 13:17:38 PDT
(In reply to comment #1) > Similar to Bug 10049 for NativePopUp? Not so much. Regressions are P1.
Stephanie Lewis
Comment 4 2006-11-06 19:46:11 PST
radar 4823054
David Kilzer (:ddkilzer)
Comment 5 2006-12-25 06:46:52 PST
This seems to be fixed in my locally-built debug build of WebKit r18411 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037).
Adele Peterson
Comment 6 2007-01-17 11:39:03 PST
I also can not reproduce in the latest build.
Alexander Kellett
Comment 7 2007-01-17 23:45:43 PST
<style> input:after { content: "yay"; } </style> <input type="text"/>
Mark Rowe (bdash)
Comment 8 2007-02-06 23:08:34 PST
With the HTML mentioned in comment 7 I see a focus ring that contains both the text field and the generated content, which is what I would expect. Firefox doesn't seem to display the generated content, so I can't test its behaviour. I'm tempted to close this as WFM, but the original report is incredibly unclear as to what the problem is so I can't be sure it's working.
Alexander Kellett
Comment 9 2007-02-07 02:29:59 PST
why would you expect the focus ring of the text field to also wrap around another element? while technically i'm sure there are reasons why you would want to assert that the after: is part of the element, does the spec really take precendence over common sense here? its looks just plain strange.
Maciej Stachowiak
Comment 10 2007-02-07 04:42:18 PST
It's arguable that this is correct behavior. Yes, it looks weird, but generated content is inherently kind of weird.
Alexander Kellett
Comment 11 2007-02-07 04:50:07 PST
okay.. disagree entirely but feel free to close.
Mark Rowe (bdash)
Comment 12 2007-02-07 04:52:40 PST
Common sense would suggest that using :after on an input element is pretty bizarre thing to do, and thus I would expect bizarre results. If the generated content is considered when constructing the outline of the element then the behaviour would be correct, otherwise it is incorrect. I cannot recall which the spec calls for.
Sam Weinig
Comment 13 2007-02-14 19:27:58 PST
I am closing this as WORKSFORME as the original bug has been fixed. Alex, if you feel the focus ring with the generated content is wrong, would please file a new bug.
Sam Weinig
Comment 14 2007-02-14 19:33:33 PST
Alex, don't worry about creating a new bug, I opened a new bug (bug 12776) to continue the discussion.
Note You need to log in before you can comment on or make changes to this bug.