A queue for DNS prefetch resolutions has been added to the platform independent WebCore code. In Qt we can use that to ensure we actually prefetch more than just the first 10 links encounted in a page, and only prefetch each hostname once during parsing.
Created attachment 169903 [details] Patch
Attachment 169903 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/network/qt/DnsPrefetchHelper.h:22: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 169903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169903&action=review >> Source/WebCore/platform/network/qt/DnsPrefetchHelper.h:22 >> +#include "config.h" > > Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] I think the style queue is right here and so I think this requires the code to be moved into DnsPrefetchHelper.cpp. I wonder why it's inline anyway :) Otherwise the change looks good!
Created attachment 169907 [details] Patch
Comment on attachment 169907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169907&action=review r=me but needs minor author fix before landing ;) > Source/WebCore/platform/network/qt/DnsPrefetchHelper.cpp:2 > - Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies) > + Copyright (C) 2009,2012 Digia Plc. and/or its subsidiary(-ies) Digia bought the Qt assets, allow the change of author of Qt code, but I'm not sure that extends to WebKit, so I suggest to maintain both here.
(In reply to comment #5) > (From update of attachment 169907 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169907&action=review > > r=me but needs minor author fix before landing ;) > > > Source/WebCore/platform/network/qt/DnsPrefetchHelper.cpp:2 > > - Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies) > > + Copyright (C) 2009,2012 Digia Plc. and/or its subsidiary(-ies) > > Digia bought the Qt assets, allow the change of author of Qt code, but I'm not sure that extends to WebKit, so I suggest to maintain both here. Okay, I would have assumed that since Nokia did that when they bought it from Trolltech, it would be the same for Digia. 2009 in this case sounds old enough to originally having been Trolltech copyright.
Created attachment 169914 [details] Patch Avoid having a useless header file, and use consistent file namnig
Comment on attachment 169914 [details] Patch Clearing flags on attachment: 169914 Committed r132074: <http://trac.webkit.org/changeset/132074>
All reviewed patches have been landed. Closing bug.