RESOLVED FIXED 99980
Web Inspector: Elaborate source panel sidebar context menus. 
https://bugs.webkit.org/show_bug.cgi?id=99980
Summary Web Inspector: Elaborate source panel sidebar context menus.
eustas.bug
Reported 2012-10-22 04:59:17 PDT
* Watches: add "Add watch expression" item to items and empty element * Watches: hide "Remove watch expression" from editing prompt context menu * Watches: add titles to header buttons * XHR Breakpoints: add "Add Breakpoint" item to items and empty element * XHR Breakpoints: add "Remove all breakpoints" item to items (when >1) * XHR Breakpoints: add title to header button * JS Breakpoints: hide "Remove/(De)Activate all breakpoints" when only 1 item present
Attachments
Patch (11.00 KB, patch)
2012-10-22 05:03 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (15.69 KB, patch)
2012-10-23 02:43 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-10-22 05:03:17 PDT
Created attachment 169879 [details] Patch
Yury Semikhatsky
Comment 2 2012-10-22 22:22:31 PDT
Comment on attachment 169879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169879&action=review > Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:198 > + var breakpointActiveTitle = WebInspector.UIString(breakpointActive ? "Deactivate All Breakpoints" : "Activate All Breakpoints"); We can change state of "Activate All Breakpoints" option on the toolbar even if there are no breakpoints so I think it could make sense to always have this option in the context menu no matter how many breakpoints we have.
eustas.bug
Comment 3 2012-10-23 02:30:48 PDT
Comment on attachment 169879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169879&action=review >> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:198 >> + var breakpointActiveTitle = WebInspector.UIString(breakpointActive ? "Deactivate All Breakpoints" : "Activate All Breakpoints"); > > We can change state of "Activate All Breakpoints" option on the toolbar even if there are no breakpoints so I think it could make sense to always have this option in the context menu no matter how many breakpoints we have. Right you are. Fixed. Also renamed "(De)Activate All Breakpoints" to "(De)Activate Breakpoints"
eustas.bug
Comment 4 2012-10-23 02:43:34 PDT
Created attachment 170095 [details] Patch
Vsevolod Vlasov
Comment 5 2012-10-23 02:59:57 PDT
Comment on attachment 170095 [details] Patch rs=me
WebKit Review Bot
Comment 6 2012-10-23 03:45:42 PDT
Comment on attachment 170095 [details] Patch Clearing flags on attachment: 170095 Committed r132199: <http://trac.webkit.org/changeset/132199>
WebKit Review Bot
Comment 7 2012-10-23 03:45:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.