* Watches: add "Add watch expression" item to items and empty element * Watches: hide "Remove watch expression" from editing prompt context menu * Watches: add titles to header buttons * XHR Breakpoints: add "Add Breakpoint" item to items and empty element * XHR Breakpoints: add "Remove all breakpoints" item to items (when >1) * XHR Breakpoints: add title to header button * JS Breakpoints: hide "Remove/(De)Activate all breakpoints" when only 1 item present
Created attachment 169879 [details] Patch
Comment on attachment 169879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169879&action=review > Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:198 > + var breakpointActiveTitle = WebInspector.UIString(breakpointActive ? "Deactivate All Breakpoints" : "Activate All Breakpoints"); We can change state of "Activate All Breakpoints" option on the toolbar even if there are no breakpoints so I think it could make sense to always have this option in the context menu no matter how many breakpoints we have.
Comment on attachment 169879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169879&action=review >> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:198 >> + var breakpointActiveTitle = WebInspector.UIString(breakpointActive ? "Deactivate All Breakpoints" : "Activate All Breakpoints"); > > We can change state of "Activate All Breakpoints" option on the toolbar even if there are no breakpoints so I think it could make sense to always have this option in the context menu no matter how many breakpoints we have. Right you are. Fixed. Also renamed "(De)Activate All Breakpoints" to "(De)Activate Breakpoints"
Created attachment 170095 [details] Patch
Comment on attachment 170095 [details] Patch rs=me
Comment on attachment 170095 [details] Patch Clearing flags on attachment: 170095 Committed r132199: <http://trac.webkit.org/changeset/132199>
All reviewed patches have been landed. Closing bug.