RESOLVED INVALID 99954
[V8] V8EnablePerContext shouldn't require document() accessor to the native object. 
https://bugs.webkit.org/show_bug.cgi?id=99954
Summary [V8] V8EnablePerContext shouldn't require document() accessor to the native o...
Hajime Morrita
Reported 2012-10-21 22:32:10 PDT
This is demanded by Bug 99780.
Attachments
Patch (2.45 KB, patch)
2012-10-21 22:35 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-10-21 22:35:48 PDT
Created attachment 169830 [details] Patch
Kentaro Hara
Comment 2 2012-10-21 23:36:13 PDT
Comment on attachment 169830 [details] Patch Looks OK
WebKit Review Bot
Comment 3 2012-10-21 23:44:19 PDT
Comment on attachment 169830 [details] Patch Clearing flags on attachment: 169830 Committed r132033: <http://trac.webkit.org/changeset/132033>
WebKit Review Bot
Comment 4 2012-10-21 23:44:23 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2012-10-23 02:43:12 PDT
Re-opened since this is blocked by bug 100097
Kent Tamura
Comment 6 2012-10-23 02:50:03 PDT
(In reply to comment #3) > (From update of attachment 169830 [details]) > Clearing flags on attachment: 169830 > > Committed r132033: <http://trac.webkit.org/changeset/132033> I rolled it out because it broke DOMWindow::pagePopupController. void V8DOMWindow::installPerContextProperties(v8::Handle<v8::Object> instance, DOMWindow* impl) { v8::Local<v8::Object> proto = v8::Local<v8::Object>::Cast(instance->GetPrototype()); ScriptExecutionContext* context = toScriptExecutionContext(proto->CreationContext()); "context" was null.
Brian Burg
Comment 7 2014-12-16 00:48:24 PST
Closing some V8-related work items.
Note You need to log in before you can comment on or make changes to this bug.