Bug 99954 - [V8] V8EnablePerContext shouldn't require document() accessor to the native object.
Summary: [V8] V8EnablePerContext shouldn't require document() accessor to the native o...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on: 100097
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-21 22:32 PDT by Hajime Morrita
Modified: 2014-12-16 00:48 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2012-10-21 22:35 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2012-10-21 22:32:10 PDT 
This is demanded by Bug 99780.
Comment 1 Hajime Morrita 2012-10-21 22:35:48 PDT 
Created attachment 169830 [details]
Patch
Comment 2 Kentaro Hara 2012-10-21 23:36:13 PDT 
Comment on attachment 169830 [details]
Patch

Looks OK
Comment 3 WebKit Review Bot 2012-10-21 23:44:19 PDT 
Comment on attachment 169830 [details]
Patch

Clearing flags on attachment: 169830

Committed r132033: <http://trac.webkit.org/changeset/132033>
Comment 4 WebKit Review Bot 2012-10-21 23:44:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2012-10-23 02:43:12 PDT 
Re-opened since this is blocked by bug 100097
Comment 6 Kent Tamura 2012-10-23 02:50:03 PDT 
(In reply to comment #3)
> (From update of attachment 169830 [details])
> Clearing flags on attachment: 169830
> 
> Committed r132033: <http://trac.webkit.org/changeset/132033>

I rolled it out because it broke DOMWindow::pagePopupController.

void V8DOMWindow::installPerContextProperties(v8::Handle<v8::Object> instance, DOMWindow* impl)
{
    v8::Local<v8::Object> proto = v8::Local<v8::Object>::Cast(instance->GetPrototype());
    ScriptExecutionContext* context = toScriptExecutionContext(proto->CreationContext());

"context" was null.
Comment 7 Brian Burg 2014-12-16 00:48:24 PST 
Closing some V8-related work items.