Bug 99946 – Add int64 wrapper for WebKit2 API

• Status: UNCONFIRMED
• Component: WebKit2

[Jiyeon Kim]

Add int64 wrapper for WebKit2 API.
Int64 value will be used to get/set application cache quota size.

[Jiyeon Kim]

Created attachment 169822 [details]
Patch

[Alexey Proskuryakov]

Thank you for providing a rationale!

Int64 can have negative values. Is that a good match for application cache quota?

[Jiyeon Kim]

(In reply to comment #2)
> Thank you for providing a rationale!
> 
> Int64 can have negative values. Is that a good match for application cache quota?
The return type of "defaultOriginQuota()" in ApplicationCacheStorage.h is "int64_t". Also "setDefaultOriginQuota()" argument is int64_t type. So I think It needs int64_t wrapper for supporting these APIs for webkit2.

[Jiyeon Kim]

(In reply to comment #3)
> (In reply to comment #2)
> > Thank you for providing a rationale!
> > 
> > Int64 can have negative values. Is that a good match for application cache quota?
> The return type of "defaultOriginQuota()" in ApplicationCacheStorage.h is "int64_t". Also "setDefaultOriginQuota()" argument is int64_t type. So I think It needs int64_t wrapper for supporting these APIs for webkit2.
But I also think that quota doesn't need to be negative value.

[Jiyeon Kim]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Thank you for providing a rationale!
> > > 
> > > Int64 can have negative values. Is that a good match for application cache quota?
> > The return type of "defaultOriginQuota()" in ApplicationCacheStorage.h is "int64_t". Also "setDefaultOriginQuota()" argument is int64_t type. So I think It needs int64_t wrapper for supporting these APIs for webkit2.
> But I also think that quota doesn't need to be negative value.
I also have a plan to make some apis for getting disk usage of local storage and application cache. These apis will use StorageTracker::diskUsageForOrigin and ApplicationCache::diskUsageForOrigin return long long type. So I think we need int64 wrapper for WebKit2.
Please review this patch.

[Alexey Proskuryakov]

Comment on attachment 169822 [details]
Patch

> I also have a plan to make some apis for getting disk usage of local storage and application cache.

These also don't need to be signed. r-, since there is no compelling rationale.

[Jiyeon Kim]

(In reply to comment #6)
> (From update of attachment 169822 [details])
> > I also have a plan to make some apis for getting disk usage of local storage and application cache.
> 
> These also don't need to be signed. r-, since there is no compelling rationale.
Is there any way better to get/set application cache quota?
I think I have two options. First, change the type of quota int64 to uint64 in webcore. Second, just use casting value for webkit2 api.
Would you give me some advice about quota value?