Bug 99931 - [EFL][WK2] Make Ewk_Error, Ewk_Resource and Ewk_Popup_Menu_Item members private
Summary: [EFL][WK2] Make Ewk_Error, Ewk_Resource and Ewk_Popup_Menu_Item members private
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 99696
  Show dependency treegraph
 
Reported: 2012-10-21 06:52 PDT by Chris Dumez
Modified: 2012-10-21 12:53 PDT (History)
7 users (show)

See Also:


Attachments
Patch (14.29 KB, patch)
2012-10-21 06:55 PDT, Chris Dumez
kenneth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (14.34 KB, patch)
2012-10-21 10:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-21 06:52:08 PDT
As part of Bug 99696, make Ewk_Error, Ewk_Resource and Ewk_Popup_Menu_Item members private.
Comment 1 Chris Dumez 2012-10-21 06:55:10 PDT
Created attachment 169797 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-21 09:34:19 PDT
Comment on attachment 169797 [details]
Patch

Rejecting attachment 169797 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 153 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
49>At revision 153.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14484206
Comment 3 Chris Dumez 2012-10-21 10:21:15 PDT
Created attachment 169806 [details]
Patch for landing

Rebased on master.
Comment 4 WebKit Review Bot 2012-10-21 12:53:12 PDT
Comment on attachment 169806 [details]
Patch for landing

Clearing flags on attachment: 169806

Committed r132007: <http://trac.webkit.org/changeset/132007>
Comment 5 WebKit Review Bot 2012-10-21 12:53:16 PDT
All reviewed patches have been landed.  Closing bug.