Bug 99928 - [CSS] shadow from radius has wrong render in webkit
Summary: [CSS] shadow from radius has wrong render in webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Takashi Sakamoto
URL:
Keywords:
Depends on:
Blocks: 27569
  Show dependency tree / graph
 
Reported: 2012-10-21 02:40 PDT by 胡伟松
Modified: 2013-03-11 21:57 PDT (History)
6 users (show)

See Also:

Attachments
results in most browsers (172.52 KB, image/png)
2012-10-21 03:04 PDT, 胡伟松 		no flags Details
test case of shadow (1.43 KB, text/html)
2012-10-21 03:06 PDT, 胡伟松 		no flags Details
Patch (6.67 KB, patch)
2012-11-08 22:02 PST, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
Patch (6.72 KB, patch)
2012-12-18 00:00 PST, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
Patch (6.72 KB, patch)
2013-03-05 03:12 PST, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
Patch for landing (13.70 KB, patch)
2013-03-05 17:10 PST, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
Patch (13.75 KB, patch)
2013-03-11 21:15 PDT, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description 胡伟松 2012-10-21 02:40:46 PDT 
please see the attachment as below!
Comment 1 胡伟松 2012-10-21 03:01:24 PDT 
render results of box shadow. please pay attention at the conner of the shadow
Comment 2 胡伟松 2012-10-21 03:04:38 PDT 
Created attachment 169792 [details]
results in most browsers

the wrong results of shadow
Comment 3 胡伟松 2012-10-21 03:06:00 PDT 
Created attachment 169793 [details]
test case of shadow
Comment 4 Takashi Sakamoto 2012-11-08 22:02:49 PST 
Created attachment 173203 [details]
Patch
Comment 5 Takashi Sakamoto 2012-12-18 00:00:04 PST 
Created attachment 179890 [details]
Patch
Comment 6 Build Bot 2012-12-18 05:16:47 PST 
Comment on attachment 179890 [details]
Patch

Attachment 179890 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15413089

New failing tests:
fast/frames/sandboxed-iframe-attribute-parsing.html
Comment 7 Takashi Sakamoto 2013-03-05 03:12:46 PST 
Created attachment 191453 [details]
Patch
Comment 8 WebKit Review Bot 2013-03-05 05:23:48 PST 
Comment on attachment 191453 [details]
Patch

Attachment 191453 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17025144

New failing tests:
fast/borders/border-radius-with-box-shadow.html
Comment 9 Simon Fraser (smfr) 2013-03-05 10:40:52 PST 
Comment on attachment 191453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191453&action=review

> Source/WebCore/ChangeLog:10
> +        corners are rounded, but others are not rounded. Need to see each
> +        corners, i.e. top-left, top-right, bottom-left and bottom-right, and

I think you're trying to say "Need to look at each corner independently".
Comment 10 Takashi Sakamoto 2013-03-05 17:10:52 PST 
Created attachment 191608 [details]
Patch for landing
Comment 11 Takashi Sakamoto 2013-03-05 17:13:32 PST 
Comment on attachment 191453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191453&action=review

Thank you for reviewing.

I checked the new failing: fast/borders/border-radius-with-box-shadow and found that its actual image looked almost the same as its expected image. So I would like to rebaseline.

>> Source/WebCore/ChangeLog:10
>> +        corners, i.e. top-left, top-right, bottom-left and bottom-right, and
> 
> I think you're trying to say "Need to look at each corner independently".

Thanks. Done.
Comment 12 WebKit Review Bot 2013-03-05 17:18:03 PST 
Attachment 191608 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/box-shadow/box-shadow-with-zero-radius-expected.html', u'LayoutTests/fast/box-shadow/box-shadow-with-zero-radius.html', u'LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/RoundedRect.cpp']" exit_code: 1
LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Takashi Sakamoto 2013-03-11 21:15:40 PDT 
Created attachment 192631 [details]
Patch
Comment 14 WebKit Review Bot 2013-03-11 21:57:29 PDT 
Comment on attachment 192631 [details]
Patch

Clearing flags on attachment: 192631

Committed r145474: <http://trac.webkit.org/changeset/145474>
Comment 15 WebKit Review Bot 2013-03-11 21:57:33 PDT 
All reviewed patches have been landed.  Closing bug.