Bug 99919 – BasicShapePolygon::path takes width instead of height for boundary calculation

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dirk Schulze]

BasicShapePolygon::path takes width instead of height for calculation.

    path.moveTo(FloatPoint(floatValueForLength(m_values.at(0), boundingBox.width()) + boundingBox.x(),
                           floatValueForLength(m_values.at(1), boundingBox.width()) + boundingBox.y()));
    for (size_t i = 2; i < length; i = i + 2) {
        path.addLineTo(FloatPoint(floatValueForLength(m_values.at(i), boundingBox.width()) + boundingBox.x(),
                                  floatValueForLength(m_values.at(i + 1), boundingBox.width()) + boundingBox.y()));

Realized it on writing further tests. Will come up with a patch soon.

[Dirk Schulze]

Created attachment 170003 [details]
Patch

[Darin Adler]

Comment on attachment 170003 [details]
Patch

The test seems a little too oblique to me. I’d put some explanatory text in it. Since it’s a ref test, the text would not make it any more prone to failure on different platforms and could make it self documenting.

[Dirk Schulze]

Committed r132257: <http://trac.webkit.org/changeset/132257>