Bug 99918 – [mac] Text with zero font size renders as 12px sometimes

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[mac] Text with zero font size renders as 12px sometimes

<rdar://problem/12512710>

Created attachment 169778 [details]
Make Font::drawGlyphs() bail out if the font size is 0

[Geoffrey Garen]

Comment on attachment 169778 [details]
Make Font::drawGlyphs() bail out if the font size is 0

View in context: https://bugs.webkit.org/attachment.cgi?id=169778&action=review

r=me

> LayoutTests/fast/text/zero-font-size-2.html:4
> +        l o r e m i s u m d o l o r

I believe you are missing a 'p'.

[WebKit Review Bot]

Comment on attachment 169778 [details]
Make Font::drawGlyphs() bail out if the font size is 0

Attachment 169778 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14462993

New failing tests:
fast/text/zero-font-size-2.html

(In reply to comment #3)
> (From update of attachment 169778 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169778&action=review
> 
> r=me
> 
> > LayoutTests/fast/text/zero-font-size-2.html:4
> > +        l o r e m i s u m d o l o r
> 
> I believe you are missing a 'p'.

The Ahem lowercase p is a thin rectangle below the baseline, and I wanted the failure case to show a simple red rectangle, so I dropped it.

Thanks for the review!

(In reply to comment #4)
> (From update of attachment 169778 [details])
> Attachment 169778 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/14462993
> 
> New failing tests:
> fast/text/zero-font-size-2.html

I wonder if the Font implementation used by chromium-xvfb has a bug similar to this. I suppose after I commit this patch I’ll be able to see what the failure looks like.

Fixed in <http://trac.webkit.org/r131995>.

(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 169778 [details] [details])
> > Attachment 169778 [details] [details] did not pass chromium-ews (chromium-xvfb):
> > Output: http://queues.webkit.org/results/14462993
> > 
> > New failing tests:
> > fast/text/zero-font-size-2.html
> 
> I wonder if the Font implementation used by chromium-xvfb has a bug similar to this. I suppose after I commit this patch I’ll be able to see what the failure looks like.

Indeed, the results at <http://build.webkit.org/results/Chromium%20Linux%20Release%20(Tests)/r131995%20(40063)/fast/text/zero-font-size-2-diffs.html> confirm this. I’ve filed bug 99920.

[Csaba Osztrogonác]

I filed a new bug report to fix this fail on Qt too - https://bugs.webkit.org/show_bug.cgi?id=100115