Bug 99898 - WTFURL: Implement KURL::setPort()
Summary: WTFURL: Implement KURL::setPort()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-19 18:26 PDT by Benjamin Poulain
Modified: 2012-10-23 14:11 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.83 KB, patch)
2012-10-19 19:19 PDT, Benjamin Poulain
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-10-19 18:26:46 PDT
Make an efficient implementation of KURL::setPort().
Comment 1 Benjamin Poulain 2012-10-19 19:19:17 PDT
Created attachment 169746 [details]
Patch
Comment 2 Adam Barth 2012-10-19 23:26:56 PDT
Comment on attachment 169746 [details]
Patch

This feels a bit oddly specific to port.  Maybe you plan to generalize it to replacing arbitrary components in future patches?
Comment 3 Benjamin Poulain 2012-10-20 00:21:26 PDT
(In reply to comment #2)
> (From update of attachment 169746 [details])
> This feels a bit oddly specific to port.  Maybe you plan to generalize it to replacing arbitrary components in future patches?

Yep, that's the idea. :)

First encode the input for any component, and pass it to a generalized version of this code. I started with port since the input is dead simple.
Comment 4 Benjamin Poulain 2012-10-23 14:11:28 PDT
Committed r132261: <http://trac.webkit.org/changeset/132261>