RESOLVED FIXED 99898
WTFURL: Implement KURL::setPort() 
https://bugs.webkit.org/show_bug.cgi?id=99898
Summary WTFURL: Implement KURL::setPort()
Benjamin Poulain
Reported 2012-10-19 18:26:46 PDT
Make an efficient implementation of KURL::setPort().
Attachments
Patch (6.83 KB, patch)
2012-10-19 19:19 PDT, Benjamin Poulain 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-10-19 19:19:17 PDT
Created attachment 169746 [details] Patch
Adam Barth
Comment 2 2012-10-19 23:26:56 PDT
Comment on attachment 169746 [details] Patch This feels a bit oddly specific to port. Maybe you plan to generalize it to replacing arbitrary components in future patches?
Benjamin Poulain
Comment 3 2012-10-20 00:21:26 PDT
(In reply to comment #2) > (From update of attachment 169746 [details]) > This feels a bit oddly specific to port. Maybe you plan to generalize it to replacing arbitrary components in future patches? Yep, that's the idea. :) First encode the input for any component, and pass it to a generalized version of this code. I started with port since the input is dead simple.
Benjamin Poulain
Comment 4 2012-10-23 14:11:28 PDT
Committed r132261: <http://trac.webkit.org/changeset/132261>
Note You need to log in before you can comment on or make changes to this bug.