Bug 99885 – WebProcess should only connect to the NetworkProcess if NetworkProcess is enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

WebProcess should only connect to the NetworkProcess if NetworkProcess is enabled

[Brady Eidson]

Created attachment 169720 [details]
Patch v1

[Alexey Proskuryakov]

Comment on attachment 169720 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=169720&action=review

> Source/WebKit2/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

!

> Source/WebKit2/ChangeLog:28
> +        (WebProcess):

prepare-ChangeLog does this to us, but it should be corrected manually when generated ChangeLog doesn't make sense..

> Source/WebKit2/Shared/WebProcessCreationParameters.cpp:50
> +    , shouldUseNetworkProcess(false)

I'm not a fan of this name. We are going to not use NetworkProcess for local files, so this "should" is way too strong.

[Brady Eidson]

Created attachment 169721 [details]
Patch v2

[Alexey Proskuryakov]

Comment on attachment 169721 [details]
Patch v2

r=me. We will also need a way to change this in WebProcess dynamically, I think.

[Brady Eidson]

(In reply to comment #4)
> (From update of attachment 169721 [details])
> r=me. We will also need a way to change this in WebProcess dynamically, I think.

Currently we treat "flipping the switch" as a "you must quit and restart" situation.

It certainly might be desirable to add the ability to dynamically change it, and shouldn't be too complex to do so in the future.

Thanks for the review!

[Brady Eidson]

http://trac.webkit.org/changeset/131963