Bug 99877 - [chromium] Remove static create functions from types WebCompositorSupport can construct
Summary: [chromium] Remove static create functions from types WebCompositorSupport can...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-19 14:57 PDT by James Robinson
Modified: 2013-01-04 12:27 PST (History)
10 users (show)

See Also:


Attachments
Patch (9.26 KB, patch)
2012-10-19 14:58 PDT, James Robinson
no flags Details | Formatted Diff | Diff
Patch (9.12 KB, patch)
2013-01-04 10:46 PST, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-10-19 14:57:51 PDT
[chromium] Remove static create functions from types WebCompositorSupport can construct
Comment 1 James Robinson 2012-10-19 14:58:08 PDT
Created attachment 169700 [details]
Patch
Comment 2 James Robinson 2012-10-19 14:58:26 PDT
This'll bust the build until https://codereview.chromium.org/11231017/ lands + rolls.
Comment 3 WebKit Review Bot 2012-10-19 15:03:30 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Peter Beverloo (cr-android ews) 2012-10-19 15:21:36 PDT
Comment on attachment 169700 [details]
Patch

Attachment 169700 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14455690
Comment 5 WebKit Review Bot 2012-10-19 15:28:11 PDT
Comment on attachment 169700 [details]
Patch

Attachment 169700 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14471217
Comment 6 Adrienne Walker 2012-10-22 12:07:50 PDT
Comment on attachment 169700 [details]
Patch

R=me.
Comment 7 James Robinson 2013-01-04 10:46:48 PST
Created attachment 181331 [details]
Patch
Comment 8 WebKit Review Bot 2013-01-04 12:27:00 PST
Comment on attachment 181331 [details]
Patch

Clearing flags on attachment: 181331

Committed r138831: <http://trac.webkit.org/changeset/138831>
Comment 9 WebKit Review Bot 2013-01-04 12:27:05 PST
All reviewed patches have been landed.  Closing bug.