RESOLVED FIXED 99855
Lexer should create 8 bit Identifiers for RegularExpressions and ASCII identifiers 
https://bugs.webkit.org/show_bug.cgi?id=99855
Summary Lexer should create 8 bit Identifiers for RegularExpressions and ASCII identi...
Michael Saboff
Reported 2012-10-19 11:10:10 PDT
Although the Lexer code has been modified to create 8 bit strings, there are two cases where 8 bit Identifiers could be created and aren't. 1. In scanRegExp(), if the source is 8 bits, both the pattern and flags can also be 8 bit identifiers. 2. When scanning an identifier in lexExpectIdentifier(), there is code to check for ASCII identifier characters and goes to a slow case for non-ASCII. The ASCII case can create 8 bit identifiers even if the source is 16 bit.
Attachments
Patch (4.45 KB, patch)
2012-10-19 11:27 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-10-19 11:27:33 PDT
Created attachment 169661 [details] Patch
WebKit Review Bot
Comment 2 2012-10-19 16:23:41 PDT
Comment on attachment 169661 [details] Patch Clearing flags on attachment: 169661 Committed r131956: <http://trac.webkit.org/changeset/131956>
WebKit Review Bot
Comment 3 2012-10-19 16:23:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.