Bug 99855 - Lexer should create 8 bit Identifiers for RegularExpressions and ASCII identifiers
Summary: Lexer should create 8 bit Identifiers for RegularExpressions and ASCII identi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-19 11:10 PDT by Michael Saboff
Modified: 2012-10-19 16:23 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.45 KB, patch)
2012-10-19 11:27 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-10-19 11:10:10 PDT
Although the Lexer code has been modified to create 8 bit strings, there are two cases where 8 bit Identifiers could be created and aren't.

1. In scanRegExp(), if the source is 8 bits, both the pattern and flags can also be 8 bit identifiers.
2. When scanning an identifier in lexExpectIdentifier(), there is code to check for ASCII identifier characters and goes to a slow case for non-ASCII. The ASCII case can create 8 bit identifiers even if the source is 16 bit.
Comment 1 Michael Saboff 2012-10-19 11:27:33 PDT
Created attachment 169661 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-19 16:23:41 PDT
Comment on attachment 169661 [details]
Patch

Clearing flags on attachment: 169661

Committed r131956: <http://trac.webkit.org/changeset/131956>
Comment 3 WebKit Review Bot 2012-10-19 16:23:44 PDT
All reviewed patches have been landed.  Closing bug.