Bug 99853 - Don't use CStrings for message receiver names and message names
Summary: Don't use CStrings for message receiver names and message names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 99871
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-19 10:45 PDT by Anders Carlsson
Modified: 2012-10-22 09:55 PDT (History)
7 users (show)

See Also:

Attachments
Patch (47.38 KB, patch)
2012-10-19 11:04 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (48.03 KB, patch)
2012-10-19 11:17 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (48.05 KB, patch)
2012-10-19 11:24 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-10-19 10:45:33 PDT 
Don't use CStrings for message receiver names and message names
Comment 1 Anders Carlsson 2012-10-19 11:04:41 PDT 
Created attachment 169651 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-19 11:07:39 PDT 
Attachment 169651 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Platform/CoreIPC/Connection.h:194:  Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2012-10-19 11:17:59 PDT 
Created attachment 169655 [details]
Patch
Comment 4 WebKit Review Bot 2012-10-19 11:20:50 PDT 
Attachment 169655 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Platform/CoreIPC/Connection.h:194:  Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Anders Carlsson 2012-10-19 11:24:17 PDT 
Created attachment 169659 [details]
Patch
Comment 6 WebKit Review Bot 2012-10-19 11:28:21 PDT 
Attachment 169659 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Platform/CoreIPC/Connection.h:194:  Local variables should never be PassOwnPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Anders Carlsson 2012-10-19 12:28:26 PDT 
Committed r131931: <http://trac.webkit.org/changeset/131931>
Comment 8 WebKit Review Bot 2012-10-19 14:29:57 PDT 
Re-opened since this is blocked by bug 99871
Comment 9 Simon Fraser (smfr) 2012-10-19 14:31:33 PDT 
This broke Safari extensions (Adblock started to block all CSS files, causing sites to render with no style). Rolling out.
Comment 10 Anders Carlsson 2012-10-22 08:58:52 PDT 
Great.
Comment 11 Anders Carlsson 2012-10-22 09:55:15 PDT 
Committed r132085: <http://trac.webkit.org/changeset/132085>