Gstreamer 1.0 not working

[Nicolas Dufresne]

Gstreamer 1.0 not working

[Nicolas Dufresne]

Created attachment 169644 [details]
Patch

[Alexis Menard (darktears)]

Comment on attachment 169644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169644&action=review

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:-91
> -    ASSERT(!ptr || !gstObjectIsFloating(GST_OBJECT(ptr)));

You should not get rid of the entire assert no? Testing pointer nullity is still valid to me.

[Philippe Normand]

Comment on attachment 169644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169644&action=review

>> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:-91
>> -    ASSERT(!ptr || !gstObjectIsFloating(GST_OBJECT(ptr)));
> 
> You should not get rid of the entire assert no? Testing pointer nullity is still valid to me.

+1

> Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:-46
> -    GstCaps* caps = gst_pad_get_current_caps(pad);
> -    if (!caps)
> -        caps = gst_pad_query_caps(pad, 0);
> -    return adoptGRef(caps); // gst_pad_query_caps and gst_pad_get_current_caps return a new reference.

gst_pad_get_current_caps() can return NULL AFAIK. What should we do in that case instead of querying the caps to the pad?

[Nicolas Dufresne]

(In reply to comment #3)
> (From update of attachment 169644 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169644&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:-91
> >> -    ASSERT(!ptr || !gstObjectIsFloating(GST_OBJECT(ptr)));
> > 
> > You should not get rid of the entire assert no? Testing pointer nullity is still valid to me.
> 
> +1

ok.

> 
> > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:-46
> > -    GstCaps* caps = gst_pad_get_current_caps(pad);
> > -    if (!caps)
> > -        caps = gst_pad_query_caps(pad, 0);
> > -    return adoptGRef(caps); // gst_pad_query_caps and gst_pad_get_current_caps return a new reference.
> 
> gst_pad_get_current_caps() can return NULL AFAIK. What should we do in that case instead of querying the caps to the pad?

Nothing, 0.10 GST_PAD_CAPS() macro you can also return NULL and this is handled gracefully by callers (by not painting).

[Nicolas Dufresne]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 169644 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=169644&action=review
> > 
> > >> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:-91
> > >> -    ASSERT(!ptr || !gstObjectIsFloating(GST_OBJECT(ptr)));
> > > 
> > > You should not get rid of the entire assert no? Testing pointer nullity is still valid to me.
> > 
> > +1
> 
> ok.
> 

Sorry I answered too fast. No the !ptr check is not valid, this is a OR. It is there only to prevent calling GST_OBJECT() with a NULL pointer. It's totally fine to store NULL in the GRefPtr.

[Philippe Normand]

Thank you Nicolas! Hopefully we'll turn gst-1.0 build support soon in the build-webkit.

[Philippe Normand]

If you're not committer yet please set the cq? flag so the commit-queue takes care of it.

[Nicolas Dufresne]

(In reply to comment #7)
> If you're not committer yet please set the cq? flag so the commit-queue takes care of it.

Sorry I forgot. Done.

[WebKit Review Bot]

Comment on attachment 169644 [details]
Patch

Rejecting attachment 169644 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Nicolas Dufresne]

(In reply to comment #9)
> (From update of attachment 169644 [details])
> Rejecting attachment 169644 [details] from commit-queue.
> 
> [e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.
> 
> - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
> 
> - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

Sorry again, selected the wrong option, hopefully setting it to ? now is enough.

[Philippe Normand]

Comment on attachment 169644 [details]
Patch

I did set it to cq+ ...

[WebKit Review Bot]

Comment on attachment 169644 [details]
Patch

Clearing flags on attachment: 169644

Committed r132081: <http://trac.webkit.org/changeset/132081>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.