Bug 99849 - Web Inspector: paint rectangles are incorrectly shown in case subframes are present
Summary: Web Inspector: paint rectangles are incorrectly shown in case subframes are p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-19 10:08 PDT by Andrey Kosyakov
Modified: 2012-10-23 10:06 PDT (History)
18 users (show)

See Also:

Attachments
Patch (14.25 KB, patch)
2012-10-19 10:14 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Patch (14.25 KB, patch)
2012-10-19 10:43 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Patch (14.33 KB, patch)
2012-10-22 01:25 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Patch (15.27 KB, patch)
2012-10-22 10:45 PDT, Andrey Kosyakov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-10-19 10:08:50 PDT 
Visualization of paint rectangles works incorrectly for pages where subframes are present: we only store the context and rectangle from last willPaint and draw it in didPaint. For nested frames, paint calls are nested, so we will only paint innermost frame and reset the last paint context, so that didPaint()s of outer frames will bail out.
Comment 1 Andrey Kosyakov 2012-10-19 10:14:43 PDT 
Created attachment 169642 [details]
Patch
Comment 2 Peter Beverloo (cr-android ews) 2012-10-19 10:41:41 PDT 
Comment on attachment 169642 [details]
Patch

Attachment 169642 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14462520
Comment 3 Andrey Kosyakov 2012-10-19 10:43:58 PDT 
Created attachment 169647 [details]
Patch
Comment 4 Early Warning System Bot 2012-10-19 10:52:54 PDT 
Comment on attachment 169647 [details]
Patch

Attachment 169647 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14466488
Comment 5 Build Bot 2012-10-19 11:08:41 PDT 
Comment on attachment 169647 [details]
Patch

Attachment 169647 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14461519
Comment 6 WebKit Review Bot 2012-10-19 11:08:52 PDT 
Comment on attachment 169647 [details]
Patch

Attachment 169647 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14460539
Comment 7 Build Bot 2012-10-19 11:16:09 PDT 
Comment on attachment 169647 [details]
Patch

Attachment 169647 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14455616
Comment 8 Peter Beverloo (cr-android ews) 2012-10-19 11:20:40 PDT 
Comment on attachment 169647 [details]
Patch

Attachment 169647 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14462532
Comment 9 Gyuyoung Kim 2012-10-19 11:55:33 PDT 
Comment on attachment 169647 [details]
Patch

Attachment 169647 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14456614
Comment 10 Early Warning System Bot 2012-10-19 15:17:36 PDT 
Comment on attachment 169647 [details]
Patch

Attachment 169647 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14458612
Comment 11 Andrey Kosyakov 2012-10-22 01:25:26 PDT 
Created attachment 169847 [details]
Patch
Comment 12 Pavel Feldman 2012-10-22 06:58:51 PDT 
Comment on attachment 169847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169847&action=review

> Source/WebCore/inspector/InspectorInstrumentation.h:145
> +    static void didPaint(Frame*);

Could you instead pass context and rect into the didPaint as well and move the paint rectangle there?
Comment 13 Andrey Kosyakov 2012-10-22 10:45:20 PDT 
Created attachment 169939 [details]
Patch
Comment 14 Andrey Kosyakov 2012-10-23 10:06:24 PDT 
Committed r132239: <http://trac.webkit.org/changeset/132239>