Bug 99845 - Remove devicePixelRatio from ViewportAttributes
Summary: Remove devicePixelRatio from ViewportAttributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-19 09:18 PDT by Andras Becsi
Modified: 2012-10-23 02:15 PDT (History)
13 users (show)

See Also:

Attachments
Patch (21.24 KB, patch)
2012-10-19 09:24 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
Patch for landing (27.09 KB, patch)
2012-10-22 05:10 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
Patch (27.38 KB, patch)
2012-10-22 07:01 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2012-10-19 09:18:11 PDT 
Remove devicePixelRatio from ViewportAttributes
Comment 1 Andras Becsi 2012-10-19 09:24:23 PDT 
Created attachment 169633 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-19 09:26:08 PDT 
Attachment 169633 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:697:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2012-10-19 09:34:58 PDT 
Thanks, that looks great.
Comment 4 Andras Becsi 2012-10-19 09:38:53 PDT 
(In reply to comment #3)
> Thanks, that looks great.

Thanks, waiting for the EWS to process the patch.
Comment 5 Build Bot 2012-10-19 09:57:38 PDT 
Comment on attachment 169633 [details]
Patch

Attachment 169633 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14466464
Comment 6 WebKit Review Bot 2012-10-19 10:03:57 PDT 
Comment on attachment 169633 [details]
Patch

Attachment 169633 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14461496
Comment 7 Peter Beverloo (cr-android ews) 2012-10-19 10:14:52 PDT 
Comment on attachment 169633 [details]
Patch

Attachment 169633 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14471092
Comment 8 Gyuyoung Kim 2012-10-19 10:15:17 PDT 
Comment on attachment 169633 [details]
Patch

Attachment 169633 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14464498
Comment 9 Andras Becsi 2012-10-22 05:10:39 PDT 
Created attachment 169880 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-10-22 05:12:37 PDT 
Attachment 169880 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:697:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 Andras Becsi 2012-10-22 05:12:48 PDT 
Comment on attachment 169880 [details]
Patch for landing

Letting the EWS' process the patch.
Comment 12 EFL EWS Bot 2012-10-22 05:42:17 PDT 
Comment on attachment 169880 [details]
Patch for landing

Attachment 169880 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14491458
Comment 13 Andras Becsi 2012-10-22 07:01:44 PDT 
Created attachment 169901 [details]
Patch

Try to fix the EFL build.
Comment 14 WebKit Review Bot 2012-10-22 07:04:13 PDT 
Attachment 169901 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:697:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Andras Becsi 2012-10-23 02:15:21 PDT 
Comment on attachment 169901 [details]
Patch

Clearing flags on attachment: 169901

Committed r132193: <http://trac.webkit.org/changeset/132193>
Comment 16 Andras Becsi 2012-10-23 02:15:30 PDT 
All reviewed patches have been landed.  Closing bug.