setRenderWithoutShowing and setRenderToOffscreenBuffer are overlapping and causing trouble, i.e. the early return in QQuickWebViewPrivate::setNeedsDisplay is wrong if the scene graph is active.
Created attachment 169604 [details] Patch
Comment on attachment 169604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169604&action=review > Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:88 > - QQuickWebViewExperimental experimental(m_view); > - experimental.setRenderToOffscreenBuffer(true); > + if (!windowShapshotEnabled()) { > + QQuickWebViewExperimental experimental(m_view); > + experimental.setRenderToOffscreenBuffer(true); > + } It would be cleaner to move it in the else of "if (PlatformWebView::windowShapshotEnabled())" in handleStatusChanged.
Created attachment 169618 [details] Patch
Comment on attachment 169618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169618&action=review > Source/WebKit2/ChangeLog:8 > + Update the comment about renderToOffscreenBuffer to better describe it's role. it's -> its > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:445 > + // This can the case when running tests. See WTR::PlatformWebView::windowShapshotEnabled. I'm not sure what this line adds, there's a "be" missing, "when running tests" is repeated from above and windowShapshotEnabled is only indirectly related.
(In reply to comment #4) > (From update of attachment 169618 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169618&action=review > > > Source/WebKit2/ChangeLog:8 > > + Update the comment about renderToOffscreenBuffer to better describe it's role. > > it's -> its I think both are correct, but fixed :) > > > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:445 > > + // This can the case when running tests. See WTR::PlatformWebView::windowShapshotEnabled. > > I'm not sure what this line adds, there's a "be" missing, "when running tests" is repeated from above and windowShapshotEnabled is only indirectly related. Removed. Landed in http://trac.webkit.org/changeset/131904