Bug 99816 – [EFL] Fix failure to access the inspector resources

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Seokju Kwon]

Fix failure to access the inspector resources.

[Seokju Kwon]

Created attachment 169563 [details]
Patch

[Seokju Kwon]

Created attachment 169567 [details]
Patch

[Thiago Marcos P. Santos]

Comment on attachment 169567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169567&action=review

> Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:147
> -    String inspectorFilesPath = "file://" + String(WEB_INSPECTOR_INSTALL_DIR);
> +    String inspectorFilesPath = ASCIILiteral(WEB_INSPECTOR_INSTALL_DIR);
>      if (access(inspectorFilesPath.utf8().data(), R_OK))
> -        inspectorFilesPath = "file://" + String(WEB_INSPECTOR_DIR);
> +        inspectorFilesPath = ASCIILiteral(WEB_INSPECTOR_DIR);
>  
> -    return inspectorFilesPath;
> +    return "file://" + inspectorFilesPath;

I don't think it is safe to assume ASCII on the install path.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 169567 [details]
Patch

The ChangeLog could be more verbose and explain what kind of failure was going on, and if possible a test for this would also be nice.

[Seokju Kwon]

(In reply to comment #3)
> (From update of attachment 169567 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169567&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp:147
> > -    String inspectorFilesPath = "file://" + String(WEB_INSPECTOR_INSTALL_DIR);
> > +    String inspectorFilesPath = ASCIILiteral(WEB_INSPECTOR_INSTALL_DIR);
> >      if (access(inspectorFilesPath.utf8().data(), R_OK))
> > -        inspectorFilesPath = "file://" + String(WEB_INSPECTOR_DIR);
> > +        inspectorFilesPath = ASCIILiteral(WEB_INSPECTOR_DIR);
> >  
> > -    return inspectorFilesPath;
> > +    return "file://" + inspectorFilesPath;
> 
> I don't think it is safe to assume ASCII on the install path.

Ok. I will remove it.

[Seokju Kwon]

(In reply to comment #4)
> (From update of attachment 169567 [details])
> The ChangeLog could be more verbose and explain what kind of failure was going on, and if possible a test for this would also be nice.

I will update the changelog.

[Seokju Kwon]

Created attachment 169591 [details]
Patch

[Thiago Marcos P. Santos]

Comment on attachment 169591 [details]
Patch

LGTM.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 169591 [details]
Patch

Looks OK.

[WebKit Review Bot]

Comment on attachment 169591 [details]
Patch

Rejecting attachment 169591 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14473265

[Seokju Kwon]

Created attachment 169816 [details]
Patch

[Ryuan Choi]

Comment on attachment 169816 [details]
Patch

Make sense.

The path may not be ASCII.

[WebKit Review Bot]

Comment on attachment 169816 [details]
Patch

Clearing flags on attachment: 169816

Committed r132018: <http://trac.webkit.org/changeset/132018>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.