Bug 99813 – Move ConnectionStack out of WebProcessConnection into its own files

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

Move ConnectionStack out of WebProcessConnection into its own files

[Brady Eidson]

Created attachment 169556 [details]
Patch v1

[WebKit Review Bot]

Attachment 169556 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit2/Shared/ConnectionStack.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 169556 [details]
Patch v1

r=me

Comment on attachment 169556 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=169556&action=review

> Source/WebKit2/Shared/ConnectionStack.cpp:2
> + * Copyright (C) 2012 Apple Inc. All rights reserved.

Did this code first appear in 2012? The file it comes from says 2010.

[Brady Eidson]

(In reply to comment #4)
> (From update of attachment 169556 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169556&action=review
> 
> > Source/WebKit2/Shared/ConnectionStack.cpp:2
> > + * Copyright (C) 2012 Apple Inc. All rights reserved.
> 
> Did this code first appear in 2012? The file it comes from says 2010.

Researched and amended.  Thanks for pointing that out.

Landed in http://trac.webkit.org/changeset/131861