Bug 99812 – [V8] DOMObjectVisitor does nothing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[V8] DOMObjectVisitor does nothing

[Adam Barth]

Created attachment 169554 [details]
Patch

[WebKit Review Bot]

Comment on attachment 169554 [details]
Patch

Rejecting attachment 169554 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/v8/V8GCController.cpp
Hunk #1 succeeded at 71 (offset 3 lines).
Hunk #2 FAILED at 325.
Hunk #3 succeeded at 435 (offset 3 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8GCController.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14462327

[Dan Carney]

(In reply to comment #0)
> [V8] DOMObjectVisitor does nothing

I have no idea what the original intention of this was, but it may have been that the author wanted the ASSERT for V8DOMWrapper::maybeDOMWrapper in V8DOMWrapper::domWrapperType?

[Adam Barth]

(In reply to comment #3)
> (In reply to comment #0)
> > [V8] DOMObjectVisitor does nothing
> 
> I have no idea what the original intention of this was, but it may have been that the author wanted the ASSERT for V8DOMWrapper::maybeDOMWrapper in V8DOMWrapper::domWrapperType?

It's possible, but as far as I know, this thing has never caught any bugs.

[Adam Barth]

Comment on attachment 169554 [details]
Patch

Clearing flags on attachment: 169554

Committed r131866: <http://trac.webkit.org/changeset/131866>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.