WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
99806
Use tile caches in place of CATiledLayer
https://bugs.webkit.org/show_bug.cgi?id=99806
Summary
Use tile caches in place of CATiledLayer
Simon Fraser (smfr)
Reported
2012-10-18 22:26:52 PDT
Use tile caches in place of CATiledLayer
Attachments
Patch
(17.35 KB, patch)
2012-10-18 22:41 PDT
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2012-10-18 22:41:50 PDT
Created
attachment 169548
[details]
Patch
Simon Fraser (smfr)
Comment 2
2012-10-18 22:42:33 PDT
<
rdar://problem/6474145
>
Ian Henderson
Comment 3
2012-10-19 00:23:21 PDT
Nice! Have we considered using tile caches for layers below the 2000px threshold as well? That way we could avoid allocating memory for offscreen layers.
Simon Fraser (smfr)
Comment 4
2012-10-19 08:30:10 PDT
Possibly; or we could use this visible rect to just avoid allocating backing store for offscreen normal layers.
Tim Horton
Comment 5
2012-10-19 13:23:05 PDT
Comment on
attachment 169548
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=169548&action=review
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1561 > + float leftEdgeDelta = paddingMultiplier * (m_visibleRect.x() - oldVisibleRect.x());
We should consider doing this for the main tile cache too.
> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:-2504 > - m_layer = PlatformCALayer::create(useTiledLayer ? PlatformCALayer::LayerTypeWebTiledLayer : PlatformCALayer::LayerTypeWebLayer, this);
Can we disappear LayerTypeWebTiledLayer entirely?
Simon Fraser (smfr)
Comment 6
2012-10-19 13:44:11 PDT
http://trac.webkit.org/changeset/131940
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug