RESOLVED FIXED 99798
Clean up RegExpKey 
https://bugs.webkit.org/show_bug.cgi?id=99798
Summary Clean up RegExpKey
Anders Carlsson
Reported 2012-10-18 19:46:02 PDT
Clean up RegExpKey
Attachments
Patch (2.90 KB, patch)
2012-10-18 19:50 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-10-18 19:50:58 PDT
Created attachment 169538 [details] Patch
Darin Adler
Comment 2 2012-10-18 20:57:05 PDT
Comment on attachment 169538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169538&action=review > Source/JavaScriptCore/ChangeLog:10 > + RegExpHash doesn't need to be a class template specialization when the class template is specialized > + for JSC::RegExpKey only. Make it a nested class of RegExp instead. Also, make operator== a friend function > + and move it inside the class. Making friend function seems good to me. Moving inside the class does not seem good to me. I find class definitions easier to read when they don’t have long function definitions inside them.
Anders Carlsson
Comment 3 2012-10-19 10:10:05 PDT
Committed r131913: <http://trac.webkit.org/changeset/131913>
Note You need to log in before you can comment on or make changes to this bug.