Clean up RegExpKey
Created attachment 169538 [details] Patch
Comment on attachment 169538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169538&action=review > Source/JavaScriptCore/ChangeLog:10 > + RegExpHash doesn't need to be a class template specialization when the class template is specialized > + for JSC::RegExpKey only. Make it a nested class of RegExp instead. Also, make operator== a friend function > + and move it inside the class. Making friend function seems good to me. Moving inside the class does not seem good to me. I find class definitions easier to read when they don’t have long function definitions inside them.
Committed r131913: <http://trac.webkit.org/changeset/131913>