Bug 99783 - [V8] fast/dom/gc-9.html fails for document.implementation
Summary: [V8] fast/dom/gc-9.html fails for document.implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 99786
  Show dependency treegraph
 
Reported: 2012-10-18 18:01 PDT by Adam Barth
Modified: 2012-10-18 18:53 PDT (History)
8 users (show)

See Also:


Attachments
Patch (12.15 KB, patch)
2012-10-18 18:03 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-10-18 18:01:52 PDT
[V8] fast/dom/gc-9.html fails for document.implementation
Comment 1 Adam Barth 2012-10-18 18:03:51 PDT
Created attachment 169523 [details]
Patch
Comment 2 Kentaro Hara 2012-10-18 18:07:04 PDT
Comment on attachment 169523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169523&action=review

Looks reasonable.

> LayoutTests/platform/chromium/fast/dom/gc-9-expected.txt:8
> +PASS: document.implementation.myCustomProperty should be 1 and is.

Looks fine.

> LayoutTests/platform/chromium/fast/dom/gc-9-expected.txt:49
> +FAIL: document.getElementsByTagName('canvas')[0].getContext('2d').myCustomProperty should be 1 but instead is undefined.

Just a confirmation: Are a bunch of FAIL lines in the expected result intended?
Comment 3 Adam Barth 2012-10-18 18:16:56 PDT
(In reply to comment #2)
> (From update of attachment 169523 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169523&action=review
> 
> > LayoutTests/platform/chromium/fast/dom/gc-9-expected.txt:49
> > +FAIL: document.getElementsByTagName('canvas')[0].getContext('2d').myCustomProperty should be 1 but instead is undefined.
> 
> Just a confirmation: Are a bunch of FAIL lines in the expected result intended?

Yes.  I will fix them in separate patches.
Comment 4 WebKit Review Bot 2012-10-18 18:53:09 PDT
Comment on attachment 169523 [details]
Patch

Clearing flags on attachment: 169523

Committed r131838: <http://trac.webkit.org/changeset/131838>
Comment 5 WebKit Review Bot 2012-10-18 18:53:13 PDT
All reviewed patches have been landed.  Closing bug.