Bug 99781 - Skia ImageDecoder doesn't set m_hasAlpha in copyBitmapData()
Summary: Skia ImageDecoder doesn't set m_hasAlpha in copyBitmapData()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peter Kasting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-18 17:43 PDT by Peter Kasting
Modified: 2012-10-18 18:02 PDT (History)
1 user (show)

See Also:

Attachments
patch v1 (1.46 KB, patch)
2012-10-18 17:45 PDT, Peter Kasting 		abarth: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
patch v1.1 (1.46 KB, patch)
2012-10-18 17:54 PDT, Peter Kasting 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2012-10-18 17:43:52 PDT 
The underlying SkBitmap has the "is opaque" bit set correctly, but the ImageFrame member isn't updated correctly.  This leads to occasional glitchiness like http://crbug.com/156526 .

This wasn't exposed until recently because Skia used to erroneously treat all images as non-opaque.
Comment 1 Peter Kasting 2012-10-18 17:45:05 PDT 
Created attachment 169516 [details]
patch v1
Comment 2 Adam Barth 2012-10-18 17:48:10 PDT 
Comment on attachment 169516 [details]
patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=169516&action=review

> Source/WebCore/ChangeLog:9
> +        No tests, since the actual effects of this bug are fickle and it's not
> +		clear how to extract and check particular subframes of an animated GIF.

Frowns.
Comment 3 WebKit Review Bot 2012-10-18 17:49:06 PDT 
Attachment 169516 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Peter Kasting 2012-10-18 17:54:25 PDT 
Created attachment 169520 [details]
patch v1.1

If I have to update the patch anyway, I'll just go ahead and land...
Comment 5 Peter Kasting 2012-10-18 18:02:39 PDT 
Fixed in r131831.