Bug 99778 - Automatically start plugins created within a user gesture, skipping snapshotting
Summary: Automatically start plugins created within a user gesture, skipping snapshotting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kiran Muppala
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-10-18 17:13 PDT by Kiran Muppala
Modified: 2012-10-18 22:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2012-10-18 17:25 PDT, Kiran Muppala
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kiran Muppala 2012-10-18 17:13:54 PDT
When plugin snapshotting is enabled, a snapshot of the plugin is displayed until the user clicks on the plugin.  However, on some sites such as cnn.com, use an image element as a placeholder for a video and replace the image with the video when the user clicks on it.  In such instances, plugin snapshotting results in the user having to click twice to watch the video.  This is undesirable.  Hence, plugins should start automatically when created within a user gesture, even if snapshotting is enabled.
Comment 1 Kiran Muppala 2012-10-18 17:25:49 PDT
Created attachment 169512 [details]
Patch
Comment 2 Kiran Muppala 2012-10-18 17:26:19 PDT
<rdar://problem/12482210>
Comment 3 Jon Lee 2012-10-18 17:44:28 PDT
Have you been able to test this?

I am not a reviewer, but I give it an unofficial r+.
Comment 4 Kiran Muppala 2012-10-18 17:47:39 PDT
(In reply to comment #3)
> Have you been able to test this?
> 
> I am not a reviewer, but I give it an unofficial r+.

Yes, I tested using cnn.com, which tends to have a "Click to Play" image element in the center, like you showed before.  The video started playing right after I clicked the image, without the interim plugin snapshot.
Comment 5 WebKit Review Bot 2012-10-18 22:36:10 PDT
Comment on attachment 169512 [details]
Patch

Clearing flags on attachment: 169512

Committed r131857: <http://trac.webkit.org/changeset/131857>
Comment 6 WebKit Review Bot 2012-10-18 22:36:14 PDT
All reviewed patches have been landed.  Closing bug.