WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
99776
[chromium] move TestRunner files into a src/ sub directory
https://bugs.webkit.org/show_bug.cgi?id=99776
Summary
[chromium] move TestRunner files into a src/ sub directory
jochen
Reported
2012-10-18 16:44:51 PDT
[chromium] move TestRunner files into a src/ sub directory
Attachments
Patch
(391.88 KB, patch)
2012-10-18 16:47 PDT
,
jochen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
jochen
Comment 1
2012-10-18 16:47:51 PDT
Created
attachment 169507
[details]
Patch
WebKit Review Bot
Comment 2
2012-10-18 16:51:54 PDT
Attachment 169507
[details]
did not pass style-queue: Tools/DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:32: You should add a blank line after implementation file's own header. [build/include_order] [4] Tools/DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:194: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:196: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.h:130: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:97: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:98: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:206: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:231: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:127: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:150: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:227: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:229: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:1184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:91: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:192: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.cppFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/D..." exit_code: 1 :223: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:290: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:299: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Tools/DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:313: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 29 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3
2012-10-18 17:31:59 PDT
Comment on
attachment 169507
[details]
Patch Clearing flags on attachment: 169507 Committed
r131828
: <
http://trac.webkit.org/changeset/131828
>
WebKit Review Bot
Comment 4
2012-10-18 17:32:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug