Bug 99775 – Build fix after r131741 for !ENABLE(CSS_SHADERS) platforms

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Dongseong Hwang]

Remove "using namespace WebKit;" in CoordinatedGraphicsArgumentCoders because WebKit namespace is only used when ENABLE(CSS_SHADERS).
It is because build fails when disabling CSS_SHADERS. For example, it brokes the Qt --minimal build.

[Dongseong Hwang]

Created attachment 169505 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 169505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:-66
> -using namespace WebKit;

I suggest just putting this inside an ifdef, too. The namespace prefix you are adding below is quite mysterious.

[Csaba Osztrogonác]

Comment on attachment 169505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review

> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:259
> +            RefPtr<CustomFilterProgram> program = WebKit::WebCustomFilterProgram::create(vertexShaderString, fragmentShaderString, programType, mixSettings);

If WebKit isn't valid namespace, I don't think if WebKit::WebCustomFilterProgram::create is valid function name.

[Csaba Osztrogonác]

Comment on attachment 169505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review

>> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:259
>> +            RefPtr<CustomFilterProgram> program = WebKit::WebCustomFilterProgram::create(vertexShaderString, fragmentShaderString, programType, mixSettings);
> 
> If WebKit isn't valid namespace, I don't think if WebKit::WebCustomFilterProgram::create is valid function name.

I didn't say anything, this code is ENABLE(CSS_SHADERS) guarded.

[Dongseong Hwang]

Created attachment 169579 [details]
Patch

[Dongseong Hwang]

(In reply to comment #2)
> I suggest just putting this inside an ifdef, too. The namespace prefix you are adding below is quite mysterious.

(In reply to comment #4)
> I didn't say anything, this code is ENABLE(CSS_SHADERS) guarded.

Thanks for advices. I guard this namespace code by ENABLE(CSS_SHADERS) as you suggested.

[Csaba Osztrogonác]

Comment on attachment 169579 [details]
Patch

Clearing flags on attachment: 169579

Committed r131878: <http://trac.webkit.org/changeset/131878>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.