Currently baselinePostion, maxAscent and maxDescent are LayoutUnits while ascent, descent and m_lineHeight are ints. This can lead to subtle alignment and rounding problems. Change baselinePosition and maxAscent/maxDescent to int to avoid these issues.
Created attachment 169492 [details] Patch
EWS might complain about indentation in InlineFlowBox. This is expected as I'm leaving the indentation as is.
Attachment 169492 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/rendering/InlineFlowBox.cpp:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/InlineFlowBox.h:178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/InlineFlowBox.h:181: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 65 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 169492 [details] Patch Attachment 169492 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14400986
Comment on attachment 169492 [details] Patch Attachment 169492 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14463170
Created attachment 169498 [details] Patch
Attachment 169498 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/rendering/InlineFlowBox.cpp:506: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/InlineFlowBox.h:178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/InlineFlowBox.h:181: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 71 files If any of these errors are false positives, please file a bug against check-webkit-style.
Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=153268
Comment on attachment 169498 [details] Patch LGTM, but keep the Mac bots green :)
Committed r132112: <http://trac.webkit.org/changeset/132112>