Bug 99730 – CachedResourceLoader::requestSVGDocument passes URL as charset

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Marja Hölttä]

CachedResourceLoader::requestSVGDocument calls CachedResourceLoader::requestResource like this:

CachedResourceHandle<CachedSVGDocument> CachedResourceLoader::requestSVGDocument(ResourceRequest& request)
{
    return static_cast<CachedSVGDocument*>(requestResource(CachedResource::SVGDocumentResource, request, request.url(), defaultCachedResourceOptions()).get());
}

and the requestResource signature is:

CachedResourceHandle<CachedResource> requestResource(CachedResource::Type, ResourceRequest&, const String& charset, const ResourceLoaderOptions&, ResourceLoadPriority = ResourceLoadPriorityUnresolved, bool isPreload = false, DeferOption = NoDefer);

So request.url() gets passed as charset.

[Marja Hölttä]

Created attachment 169428 [details]
Patch

[WebKit Review Bot]

Comment on attachment 169428 [details]
Patch

Clearing flags on attachment: 169428

Committed r131782: <http://trac.webkit.org/changeset/131782>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This should have had an explanation of why a test case wasn't possible.

(In reply to comment #4)
> This should have had an explanation of why a test case wasn't possible.

Sorry, I had assumed that it was obvious

Since the URL can't be parsed as a valid encoding, it was effectively treated as no encoding. Therefore, there's no change in functionality.

Would you prefer to reland the patch with an updated ChangeLog?