RESOLVED FIXED 99727
Make conversion between JSStringRef and WKStringRef work without character size conversions 
https://bugs.webkit.org/show_bug.cgi?id=99727
Summary Make conversion between JSStringRef and WKStringRef work without character si...
Michael Saboff
Reported 2012-10-18 09:42:27 PDT
The APIs WKStringRef WKStringCreateWithJSString(JSStringRef) and JSStringRef WKStringCopyJSString(WKStringRef) call the characters() method on their argument string to create the wrapped return string. This will cause 8-bit argument string to be up converted and create the results strings as 16 bit strings. Instead both of these API's should use the wrapped WTFString objects so that 8-bit strings stay that way. Due to threading, these API's need to create copies, but that is already done in OpaqueJSString.
Attachments
Patch (3.39 KB, patch)
2012-10-18 09:54 PDT, Michael Saboff 		andersca: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Patch with fix to #include typo (3.39 KB, patch)
2012-10-18 10:18 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-10-18 09:54:31 PDT
Created attachment 169427 [details] Patch
Anders Carlsson
Comment 2 2012-10-18 09:58:36 PDT
Comment on attachment 169427 [details] Patch Very nice!
Gyuyoung Kim
Comment 3 2012-10-18 10:00:30 PDT
Comment on attachment 169427 [details] Patch Attachment 169427 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14455140
Early Warning System Bot
Comment 4 2012-10-18 10:01:34 PDT
Comment on attachment 169427 [details] Patch Attachment 169427 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14461073
Michael Saboff
Comment 5 2012-10-18 10:18:03 PDT
Created attachment 169432 [details] Patch with fix to #include typo
WebKit Review Bot
Comment 6 2012-10-18 11:07:16 PDT
Comment on attachment 169432 [details] Patch with fix to #include typo Clearing flags on attachment: 169432 Committed r131777: <http://trac.webkit.org/changeset/131777>
WebKit Review Bot
Comment 7 2012-10-18 11:07:19 PDT
All reviewed patches have been landed. Closing bug.
Roger Fong
Comment 8 2012-10-18 14:17:11 PDT
Fixed windows build: http://trac.webkit.org/changeset/131801
Michael Saboff
Comment 9 2012-10-18 14:21:14 PDT
(In reply to comment #8) > Fixed windows build: http://trac.webkit.org/changeset/131801 Thanks.
Note You need to log in before you can comment on or make changes to this bug.