RESOLVED FIXED 99717
Web Inspector: merge "docked" state into the "dock side" enum. 
https://bugs.webkit.org/show_bug.cgi?id=99717
Summary Web Inspector: merge "docked" state into the "dock side" enum.
Pavel Feldman
Reported 2012-10-18 07:47:51 PDT
Otherwise, it is hard to manage these inter-dependent flags.
Attachments
Patch (17.44 KB, patch)
2012-10-19 05:33 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] for bots (22.32 KB, patch)
2012-10-19 09:24 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] for bots (22.53 KB, patch)
2012-10-19 10:06 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-10-19 05:33:47 PDT
Created attachment 169602 [details] Patch
WebKit Review Bot
Comment 2 2012-10-19 05:35:57 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Build Bot
Comment 3 2012-10-19 06:02:32 PDT
Comment on attachment 169602 [details] Patch Attachment 169602 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14463466
kov's GTK+ EWS bot
Comment 4 2012-10-19 07:56:46 PDT
Comment on attachment 169602 [details] Patch Attachment 169602 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14471056
Build Bot
Comment 5 2012-10-19 08:41:27 PDT
Comment on attachment 169602 [details] Patch Attachment 169602 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14459528
Pavel Feldman
Comment 6 2012-10-19 09:24:54 PDT
Created attachment 169634 [details] [Patch] for bots
Build Bot
Comment 7 2012-10-19 09:52:56 PDT
Comment on attachment 169634 [details] [Patch] for bots Attachment 169634 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14465507
Pavel Feldman
Comment 8 2012-10-19 10:06:00 PDT
Created attachment 169640 [details] [Patch] for bots
Pavel Feldman
Comment 9 2012-10-19 13:04:24 PDT
Committed r131936: <http://trac.webkit.org/changeset/131936>
Tony Chang
Comment 10 2012-10-19 14:38:34 PDT
(In reply to comment #9) > Committed r131936: <http://trac.webkit.org/changeset/131936> This broke the build with clang: ../../content/renderer/devtools_client.h:44:16: error: 'requestDockWindow' marked 'override' but does not override any member functions virtual void requestDockWindow() OVERRIDE; ^ ../../content/renderer/devtools_client.h:45:16: error: 'requestUndockWindow' marked 'override' but does not override any member functions virtual void requestUndockWindow() OVERRIDE; ^ Looks like we need to remove the code Chrome side first?
Tony Chang
Comment 11 2012-10-19 14:55:09 PDT
Reverted r131936 for reason: Broke the clang build Committed r131946: <http://trac.webkit.org/changeset/131946>
Pavel Feldman
Comment 12 2012-10-22 01:52:26 PDT
Committed r132045: <http://trac.webkit.org/changeset/132045>
Yury Semikhatsky
Comment 13 2012-10-22 02:01:15 PDT
Comment on attachment 169640 [details] [Patch] for bots Clearing r? from landed patch.
Timothy Hatcher
Comment 14 2012-10-22 23:30:44 PDT
This caused bug 100080.
Note You need to log in before you can comment on or make changes to this bug.